Review main Merged

51592[BUGFIX] Improve preview of InputLinkelement

Georg Ringer CR +2 V +2 Normal +60 −21 updated 02/22/17, 08:23

Commit message

- Use a div instead of an input field to avoid issues like
  tooltip not shown because of the disabled attribute.
- Trigger onchange from LinkBrowser popup
- If no value found, show the input field, which makes it easier
  to e.g. enter an external url.
- Show helpful title for toggle button on hover

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Josef Glatz +1
    • Georg Ringer +1
  • Verified V +2
    • Andreas Kienast +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 6

Review log 1931

Show 56 earlier messages
  1. Georg Ringer uploaded patch set 1 02/08/17, 18:52

  2. TYPO3com voted on patch set 1 V +1 02/08/17, 18:56 Completed build in 04m 40s on Wed, 8 Feb, 07:56 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7801

  3. Josef Glatz commented on patch set 1 CR -1 02/08/17, 22:16

    Much better now. Actually 2 things come to mind: a) After changing the value of the input, the value of the explanation should be cleared?! I think updating via ajax isn't needed for such a feature. Is ok for an editor imo. b) seems like the tooltip has only a limited width. What about not displaying a tooltip for this input field?
  4. Christian Kuhn commented on patch set 1 CR -1 02/09/17, 22:50

    FormEngineLinkBrowserAdapter.js:63

    this, together with the change in EditDocumentController looks fishy. Creates a direct connection between the two. I wonder if there is no more elegant solution.
  5. Andreas Kienast commented on patch set 1 CR -1 02/12/17, 19:57

    InputLinkElement.php:212

    New rule in LESS, please

    FormEngine.js:1014

    Both variables are not used

    FormEngine.js:1014

    In general: mixed indentation!

    FormEngine.js:1019

    Merge these lines

    FormEngineLinkBrowserAdapter.js:63 Reply

    I'd drop the code in EditDocumentController and use it directly in here. I don't see the need of having a dedicated function.
  6. Georg Ringer uploaded patch set 2 02/12/17, 20:10

  1. Andreas Kienast commented on patch set 2 02/12/17, 20:12

    FormEngineLinkBrowserAdapter.js:63

    You forgot something ^^

    FormEngineLinkBrowserAdapter.js:64

    wrong indentation
  2. TYPO3com voted on patch set 2 V +1 02/12/17, 20:16 Completed build in 06m 09s on Sun, 12 Feb, 09:16 PM Test Summary: 56237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7967

  3. Georg Ringer uploaded patch set 3 02/17/17, 11:55

  4. TYPO3com voted on patch set 3 V +1 02/17/17, 12:00 Completed build in 04m 56s on Fri, 17 Feb, 01:00 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8205

  5. Josef Glatz uploaded patch set 4 02/18/17, 21:31

  6. Josef Glatz commented on patch set 4 02/18/17, 21:31

    I've added a title tag for improved usability.
  7. Josef Glatz commented on patch set 4 02/18/17, 21:35

    @Georg: when field is empty and I add a value through the LinkBrowser popup the new value is shown in the input field. It would be very nice if the new value (which is set by Link Browser popup) is also shown even if the input field contained a value earlier and the link explanation is active
  8. TYPO3com voted on patch set 4 V -1 02/18/17, 21:39 Completed build in 08m 02s on Sat, 18 Feb, 10:39 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8236

  9. TYPO3com commented on patch set 4 02/18/17, 21:49 Completed build in 26m 30s on Sat, 18 Feb, 10:49 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8236

  10. Christian Kuhn rebased onto patch set 5 02/18/17, 22:59

  11. TYPO3com commented on patch set 4 02/18/17, 23:07 Completed build in 2h 02m 52s on Sun, 19 Feb, 12:07 AM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8236

  12. TYPO3com voted on patch set 5 V -1 02/18/17, 23:09 Completed build in 08m 57s on Sun, 19 Feb, 12:09 AM Test Summary: 1 of 56364 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8245

  13. TYPO3com voted on patch set 5 V +1 02/18/17, 23:13 Completed build in 22m 05s on Sun, 19 Feb, 12:13 AM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8245

  14. Andreas Kienast uploaded patch set 6 02/19/17, 17:56

  15. Andreas Kienast uploaded patch set 7 02/19/17, 17:58

  16. Andreas Kienast commented on patch set 7 02/19/17, 17:59

    - Changed event listening - Use promises instead of deprecated async: false - Do not explicitly trigger the `change` event (implicitly done by `val()`)
  17. TYPO3com voted on patch set 6 V +1 02/19/17, 18:03 Completed build in 07m 33s on Sun, 19 Feb, 07:03 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8267

  18. TYPO3com voted on patch set 7 V +1 02/19/17, 18:06 Completed build in 07m 44s on Sun, 19 Feb, 07:06 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8268

  19. Georg Ringer updated the commit message in patch set 8 02/22/17, 07:33

  20. Georg Ringer voted on patch set 8 CR +1 V +1 02/22/17, 07:33

  21. TYPO3com voted on patch set 8 V -1 02/22/17, 07:41 Completed build in 08m 04s on Wed, 22 Feb, 08:41 AM Test Summary: 2 of 56387 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8355

  22. TYPO3com voted on patch set 8 V +1 02/22/17, 07:45 Completed build in 20m 16s on Wed, 22 Feb, 08:45 AM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8355

  23. Josef Glatz voted on patch set 8 CR +1 V +1 02/22/17, 08:13

  24. Andreas Kienast voted on patch set 8 CR +2 V +2 02/22/17, 08:23

  25. Gerrit merged patch set 8 02/22/17, 08:23