Review main Merged

51593[BUGFIX] Use mb_strlen in StringLengthValidator

Georg Ringer CR +2 V +2 Easy +7 −5 updated 02/09/17, 08:22

Commit message

By using mb_strlen for checking the length, the
check counts multibyte values now correctly.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stephan Großberndt +1
    • Mona Muzaffar +1
    • Mathias Brodala +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Mona Muzaffar +1
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Georg Ringer uploaded patch set 1 02/08/17, 19:01

  2. TYPO3com voted on patch set 1 V -1 02/08/17, 19:06 Completed build in 05m 28s on Wed, 8 Feb, 08:06 PM Test Summary: 1 of 56231 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7802

  3. TYPO3com voted on patch set 1 V +1 02/08/17, 19:24 Completed build in 28m 26s on Wed, 8 Feb, 08:24 PM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7802

  4. Philipp Gampe voted on patch set 1 CR +1 02/08/17, 19:34

  5. Thomas Hohn voted on patch set 1 CR +1 02/08/17, 19:36

  6. Jigal van Hemert voted on patch set 1 CR +1 V +1 02/08/17, 21:33

  7. Josef Glatz voted on patch set 1 CR +1 02/08/17, 21:55

  8. Oliver Hader voted on patch set 1 CR +1 02/08/17, 22:32

  9. Stephan Großberndt updated the commit message in patch set 2 02/09/17, 00:06

  10. Stephan Großberndt commented on patch set 2 CR +1 02/09/17, 00:08

    Sorry to kill the votes. Please revote.
  11. TYPO3com voted on patch set 2 V +1 02/09/17, 00:11 Completed build in 05m 01s on Thu, 9 Feb, 01:11 AM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7814

  12. Philipp Gampe voted on patch set 2 CR +1 V +1 02/09/17, 00:32

  13. Mona Muzaffar voted on patch set 2 CR +1 V +1 02/09/17, 08:12

  14. Mathias Brodala commented on patch set 2 CR +1 02/09/17, 08:20

    StringLengthValidatorTest.php:276

    :-)
  15. Markus Klein voted on patch set 2 CR +2 V +2 02/09/17, 08:21

  16. Gerrit merged patch set 2 02/09/17, 08:22