Review main Merged

51608[BUGFIX] Do not use array assignment for string variable

Sascha Egerer CR +2 V +2 Easy +3 −3 updated 02/10/17, 09:46

Commit message

In PHP 7.1 it is not possible anymore to assign a value to
a variable of type string with `[]` appended. In older PHP
versions the variables was silently converted to an array but
in PHP 7.1 a warning is thrown.
Beside that the variable must be of type string anyway and not
an array.

Review

  • Code review CR +2
    • Markus Klein +2
    • Johannes Kasberger +1
  • Verified V +2
    • Markus Klein +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1520

  1. Sascha Egerer uploaded patch set 1 02/09/17, 12:01

  2. TYPO3com voted on patch set 1 V -1 02/09/17, 12:06 Completed build in 05m 39s on Thu, 9 Feb, 01:06 PM Test Summary: 1 of 56231 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7835

  3. Wouter Wolters updated the commit message in patch set 2 02/09/17, 13:47

  4. TYPO3com voted on patch set 2 V +1 02/09/17, 13:52 Completed build in 04m 30s on Thu, 9 Feb, 02:52 PM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7836

  5. Thomas Hohn voted on patch set 2 CR +1 02/09/17, 22:07

  6. Markus Klein commented on patch set 2 CR -1 02/09/17, 22:24

    The whole method usage is a mess. The variable name has to be fixed to reflect that it is a single string not an array. Many functions use a mixed type annotation instead of string.

    CommandLineBackendUserRemovalUpdate.php:66

    name does not match parameter name
  7. Markus Klein uploaded patch set 3 02/09/17, 22:36

  8. Markus Klein voted on patch set 3 CR +1 V +1 02/09/17, 22:38

  9. TYPO3com voted on patch set 3 V -1 02/09/17, 22:52 Completed build in 15m 52s on Thu, 9 Feb, 11:52 PM Test Summary: 1 of 56231 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7877

  10. Sascha Egerer uploaded patch set 4 02/09/17, 23:02

  11. Sascha Egerer uploaded patch set 5 02/09/17, 23:04

  12. Sascha Egerer commented on patch set 5 02/09/17, 23:05

    Sorry for repuhsing that. I had that change already pending and closed my mac to early before it was pushed. Now it has been pushed... ;-) And yes i agree that the whole thing is a mess but thats not related to that patch
  13. TYPO3com voted on patch set 4 V +1 02/09/17, 23:08 Completed build in 05m 44s on Fri, 10 Feb, 12:08 AM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7878

  14. TYPO3com voted on patch set 5 V +1 02/09/17, 23:09 Completed build in 05m 36s on Fri, 10 Feb, 12:09 AM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7879

  15. Markus Klein commented on patch set 5 02/10/17, 09:31

    Well it is related, since it does not properly define the expected data type, hence this issue only occurs since the data type had been changed and this place was forgotten to adjust the code. So IMO we must fix that for all classes.
  16. Markus Klein commented on patch set 5 CR +1 V +1 02/10/17, 09:42

    but lets get that one in and I'll push the rest as a dedicated patch
  17. Johannes Kasberger voted on patch set 5 CR +1 V +1 02/10/17, 09:46

  18. Markus Klein voted on patch set 5 CR +2 V +2 02/10/17, 09:46

  19. Wouter Wolters voted on patch set 5 CR +2 V +2 02/10/17, 09:46

  20. Gerrit merged patch set 5 02/10/17, 09:46