Review main Merged

51615[TASK] Allow risky fixers

Jan Kiesewetter CR +2 V +2 Easy +1 −0 updated 02/10/17, 00:19

Commit message

php-cs-fixer added "no_alias_functions" to its ruleset of risky fixers.
This patch allows risky fixers to be run.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Jan Kiesewetter uploaded patch set 1 02/09/17, 19:42

  2. TYPO3com voted on patch set 1 V +1 02/09/17, 19:47 Completed build in 05m 15s on Thu, 9 Feb, 08:47 PM Test Summary: 56231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7845

  3. Tymoteusz Motylewski commented on patch set 1 02/09/17, 20:52

    what are the consequences? why are they called "risky"?
  4. Nicole Hummel updated the commit message in patch set 2 02/09/17, 23:57

  5. Nicole Hummel commented on patch set 2 02/09/17, 23:58

    from documentation: "Risky rule is a rule, which could change code behaviour"
  6. Nicole Hummel voted on patch set 2 CR +1 V +1 02/09/17, 23:58

  7. TYPO3com voted on patch set 2 V +1 02/10/17, 00:02 Completed build in 05m 02s on Fri, 10 Feb, 01:02 AM Test Summary: 56207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7881

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 02/10/17, 00:19

  9. Gerrit merged patch set 2 02/10/17, 00:19