Review main Merged

51624[CLEANUP] Use correct type hint for messages in install tool updates

Markus Klein CR +2 V +2 Hard +122 −146 updated 02/10/17, 19:04

Commit message

The data type of customMessage has been changed to string a while ago
but the method signatures still have a mixed-type.
Normalize this over all updates to make things consistent again.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Josef Glatz +1
    • Sascha Egerer +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Josef Glatz +1
    • Sascha Egerer +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 34

Show 14 more files

Review log 1822

  1. Markus Klein uploaded patch set 1 02/10/17, 09:54

  2. TYPO3com voted on patch set 1 V +1 02/10/17, 09:59 Completed build in 04m 50s on Fri, 10 Feb, 10:59 AM Test Summary: 56207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7893

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 02/10/17, 10:08

  4. Markus Sommer commented on patch set 1 CR +1 V +1 02/10/17, 11:50

    Woks :)
  5. Josef Glatz commented on patch set 1 02/10/17, 12:06

    Compatibility6ExtractionUpdate.php:97

    is "mixed" intentional here?
  6. Josef Glatz voted on patch set 1 CR -1 02/10/17, 12:06

  7. Markus Klein commented on patch set 2 02/10/17, 14:47

    Published edit on patch set 1.
  8. TYPO3com voted on patch set 2 V +1 02/10/17, 14:52 Completed build in 04m 48s on Fri, 10 Feb, 03:52 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7905

  9. Josef Glatz voted on patch set 2 CR +1 02/10/17, 16:03

  10. Andreas Kienast voted on patch set 2 CR +1 V +1 02/10/17, 17:27

  11. Sascha Egerer voted on patch set 2 CR +1 V +1 02/10/17, 18:01

  12. Sascha Egerer commented on patch set 2 CR -1 V 0 02/10/17, 18:14

    Will fix a comment
  13. Sascha Egerer commented on patch set 2 02/10/17, 18:29

    FrontendUserImageUpdateWizard.php:166

    The return value should not rely on a parameter that is passed into the function.

    FrontendUserImageUpdateWizard.php:223

    Should be $customMessage

    DeprecatedRteProperties.php:204

    Should be $customMessage

    RteAcronymButtonRenamedToAbbreviation.php:78

    message instead of messages
  14. Sascha Egerer uploaded patch set 3 02/10/17, 18:36

  15. Sascha Egerer commented on patch set 4 02/10/17, 18:38

    Published edit on patch set 3.
  16. TYPO3com voted on patch set 3 V +1 02/10/17, 18:41 Completed build in 05m 37s on Fri, 10 Feb, 07:41 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7916

  17. Sascha Egerer voted on patch set 4 CR +1 V +1 02/10/17, 18:42

  18. TYPO3com voted on patch set 4 V +1 02/10/17, 18:43 Completed build in 05m 41s on Fri, 10 Feb, 07:43 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7917

  19. Christian Kuhn voted on patch set 4 CR +1 V +1 02/10/17, 18:51

  20. Josef Glatz voted on patch set 4 CR +1 V +1 02/10/17, 18:53

  21. Andreas Kienast voted on patch set 4 CR +2 V +2 02/10/17, 19:04

  22. Gerrit merged patch set 4 02/10/17, 19:04