51624[CLEANUP] Use correct type hint for messages in install tool updates
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Josef Glatz +1
- Sascha Egerer +1
- Christian Kuhn +1
-
Verified V +2
- Andreas Kienast +2
- Josef Glatz +1
- Sascha Egerer +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 34
- typo3/sysext/install/Classes/Updates/AbstractDownloadExtensionUpdate.php+5 −5
- typo3/sysext/install/Classes/Updates/AbstractUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/AccessRightParametersUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/BackendUserStartModuleUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/BulletContentElementUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/Compatibility6ExtractionUpdate.php1+3 −3
- typo3/sysext/install/Classes/Updates/ContentTypesToTextMediaUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/DatabaseCharsetUpdate.php+3 −3
- typo3/sysext/install/Classes/Updates/DatabaseRowsUpdateWizard.php+2 −2
- typo3/sysext/install/Classes/Updates/DbalAndAdodbExtractionUpdate.php+4 −4
- typo3/sysext/install/Classes/Updates/ExtensionManagerTables.php+3 −12
- typo3/sysext/install/Classes/Updates/FileListIsStartModuleUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/FilesReplacePermissionUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/FillTranslationSourceField.php+2 −2
- typo3/sysext/install/Classes/Updates/FinalDatabaseSchemaUpdate.php+3 −11
- typo3/sysext/install/Classes/Updates/FrontendUserImageUpdateWizard.php2+9 −9
- typo3/sysext/install/Classes/Updates/InitialDatabaseSchemaUpdate.php+3 −11
- typo3/sysext/install/Classes/Updates/LanguageIsoCodeUpdate.php+3 −2
- typo3/sysext/install/Classes/Updates/MediaceExtractionUpdate.php+3 −3
- typo3/sysext/install/Classes/Updates/MigrateCscStaticTemplateUpdate.php+2 −2
Show 14 more files
- typo3/sysext/install/Classes/Updates/MigrateFscStaticTemplateUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/MigrateMediaToAssetsForTextMediaCe.php+4 −4
- typo3/sysext/install/Classes/Updates/MigrateShortcutUrlsAgainUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/OpenidExtractionUpdate.php+3 −3
- typo3/sysext/install/Classes/Updates/PageShortcutParentUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/ProcessedFileChecksumUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/SectionFrameToFrameClassUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/SplitMenusUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/TableFlexFormToTtContentFieldsUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/UploadContentElementUpdate.php+2 −2
- typo3/sysext/install/Classes/Updates/WizardDoneToRegistry.php+2 −2
- typo3/sysext/install/Classes/Updates/WorkspacesNotificationSettingsUpdate.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/Hook/Install/DeprecatedRteProperties.php1+19 −19
- typo3/sysext/rtehtmlarea/Classes/Hook/Install/RteAcronymButtonRenamedToAbbreviation.php1+17 −17
Review log 1822
-
Markus Klein uploaded patch set 1 02/10/17, 09:54
-
TYPO3com voted on patch set 1 V +1 02/10/17, 09:59 Completed build in 04m 50s on Fri, 10 Feb, 10:59 AM Test Summary: 56207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7893
-
Wouter Wolters voted on patch set 1 CR +1 V +1 02/10/17, 10:08
-
Markus Sommer commented on patch set 1 CR +1 V +1 02/10/17, 11:50
Woks :) -
Josef Glatz commented on patch set 1 02/10/17, 12:06
Compatibility6ExtractionUpdate.php:97is "mixed" intentional here? -
Josef Glatz voted on patch set 1 CR -1 02/10/17, 12:06
-
Markus Klein commented on patch set 2 02/10/17, 14:47
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 02/10/17, 14:52 Completed build in 04m 48s on Fri, 10 Feb, 03:52 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7905
-
Josef Glatz voted on patch set 2 CR +1 02/10/17, 16:03
-
Andreas Kienast voted on patch set 2 CR +1 V +1 02/10/17, 17:27
-
Sascha Egerer voted on patch set 2 CR +1 V +1 02/10/17, 18:01
-
Sascha Egerer commented on patch set 2 CR -1 V 0 02/10/17, 18:14
Will fix a comment -
Sascha Egerer commented on patch set 2 02/10/17, 18:29
FrontendUserImageUpdateWizard.php:166The return value should not rely on a parameter that is passed into the function.FrontendUserImageUpdateWizard.php:223Should be $customMessageDeprecatedRteProperties.php:204Should be $customMessageRteAcronymButtonRenamedToAbbreviation.php:78message instead of messages -
Sascha Egerer uploaded patch set 3 02/10/17, 18:36
-
Sascha Egerer commented on patch set 4 02/10/17, 18:38
Published edit on patch set 3. -
TYPO3com voted on patch set 3 V +1 02/10/17, 18:41 Completed build in 05m 37s on Fri, 10 Feb, 07:41 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7916
-
Sascha Egerer voted on patch set 4 CR +1 V +1 02/10/17, 18:42
-
TYPO3com voted on patch set 4 V +1 02/10/17, 18:43 Completed build in 05m 41s on Fri, 10 Feb, 07:43 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7917
-
Christian Kuhn voted on patch set 4 CR +1 V +1 02/10/17, 18:51
-
Josef Glatz voted on patch set 4 CR +1 V +1 02/10/17, 18:53
-
Andreas Kienast voted on patch set 4 CR +2 V +2 02/10/17, 19:04
-
Gerrit merged patch set 4 02/10/17, 19:04