51632[BUGFIX] Do not apply cropping to image used in crop wizard
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 910
-
Sascha Egerer uploaded patch set 1 02/10/17, 21:45
-
TYPO3com voted on patch set 1 V +1 02/10/17, 21:50 Completed build in 05m 08s on Fri, 10 Feb, 10:50 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7923
-
Helmut Hummel commented on patch set 1 CR -1 02/12/17, 15:10
-
Sascha Egerer commented on patch set 1 CR -1 02/13/17, 21:25
Looks like the problem is based on the database changes of I0dac002104cddb2e268c4f7b99dc0f48ea606200 I'll envestigate -
Helmut Hummel commented on patch set 1 02/14/17, 08:23
I0dac002104cddb2e268c4f7b99dc0f48ea606200 is conceptually challenging as there might be different expectations how the cropper should behave on sys_file_reference level, when there is a crop on sys_file_metadata level imho this should be exposed to the UI somehow then -
Sascha Egerer commented on patch set 1 02/14/17, 10:52
Initially it was planned that the cropping from the file is inherited like all the other metadata too. You can then overwrite it in the file reference -
Helmut Hummel commented on patch set 1 02/14/17, 22:51
> Initially it was planned that the cropping from the file is inherited like all the other metadata too. You can then overwrite it in the file reference yes, sounds reasonable. however with cropping, the ui gets a little bit more complicated than with text fields (depending on how you want to show the crop in the meta data when defining the crop in the reference) -
Mona Muzaffar commented on patch set 1 02/24/17, 14:12
is this patch still under discussion? -
Helmut Hummel commented on patch set 1 CR -2 02/24/17, 14:22
Imho that is wrong for now -
Helmut Hummel abandoned the change 02/24/17, 14:22
ImageCropping.html:70