Review main Merged

51636[BUGFIX] Skip failing unit tests if preconditions not available

Nicole Hummel CR +2 V +2 Easy +7 −0 updated 02/11/17, 16:00

Commit message

The unit tests for RedisSessionBackendTest rely on a class \Redis
which might not be available on all systems. Therefore the tests
should be skipped to not fail.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Nicole Hummel uploaded patch set 1 02/11/17, 15:52

  2. Nicole Hummel commented on patch set 1 02/11/17, 15:53

    I'm not sure if I missed any dependency but on my Windows system \Redis class is not available
  3. TYPO3com voted on patch set 1 V +1 02/11/17, 15:57 Completed build in 04m 52s on Sat, 11 Feb, 04:57 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7930

  4. Christian Kuhn commented on patch set 1 CR +1 V +1 02/11/17, 15:58

    good catch. the according functionals do have a test for this already, but we missed that with the unit tests.
  5. Andreas Kienast voted on patch set 1 CR +2 V +2 02/11/17, 16:00

  6. Gerrit merged patch set 1 02/11/17, 16:00