Review main Merged

51637[BUGFIX] Fix wrong path handling in DocumentationFile

Nicole Hummel CR +2 V +2 Easy +4 −4 updated 02/16/17, 15:36

Commit message

Currently several unit tests are failing on Windows system due to the
usage of DIRECTORY_SEPARATOR. This patch ensures unix-like paths are
used everywhere and tests are running again.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jasmina Ließmann +1
    • Thomas Hohn +1
    • Christian Matthes +1
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Jasmina Ließmann +1
    • Christian Matthes +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1213

  1. Nicole Hummel uploaded patch set 1 02/11/17, 16:11

  2. TYPO3com voted on patch set 1 V +1 02/11/17, 16:16 Completed build in 04m 53s on Sat, 11 Feb, 05:16 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7932

  3. Benni Mack voted on patch set 1 CR +1 02/12/17, 21:18

  4. Thomas Hohn voted on patch set 1 CR +1 02/13/17, 08:00

  5. Jasmina Ließmann voted on patch set 1 CR +1 V +1 02/13/17, 13:13

  6. Christian Matthes voted on patch set 1 CR +1 V +1 02/13/17, 16:08

  7. Markus Klein voted on patch set 1 CR +2 V +2 02/13/17, 21:55

  8. Gerrit merged patch set 1 02/13/17, 21:55

  9. Susi Moog commented on patch set 2 02/16/17, 15:29

    post -1 fails on System: Windows NT 6.1 build 7601 (Windows 7 Professional Edition Service Pack 1) AMD64 Compiler: MSVC14 (Visual C++ 2015) Web-Server: Microsoft-IIS/7.5 PHP Version: 7.0.15
  10. Susi Moog commented on patch set 2 02/16/17, 15:29

    (and worked on that system before the patch)
  11. Susi Moog commented on patch set 2 02/16/17, 15:31

    also fails on: Windows 8.1 IIS 8.5.9600.16384 PHP-Version 7.0.7
  12. Nicole Hummel commented on patch set 2 02/16/17, 15:34

    Can you point out your errors please?
  13. Susi Moog commented on patch set 2 02/16/17, 15:36

    Uncaught TYPO3 Exception: the given file does not belong to the changelog dir. Aborting. C:/Projects/ProjectFolder/Source/vendor/typo3/cms/typo3...reaking-43085-RenamedGraphicsProcessorSettings.rst Revert of this patch fixes the exception.