51652[CLEANUP] Remove unused splat operator in AreaTest
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
-
Verified V +2
- Helmut Hummel +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 912
-
Ingo Pfennigstorf uploaded patch set 1 02/13/17, 09:12
-
Cedric Ziel voted on patch set 1 CR +1 V +1 02/13/17, 09:14
-
Ingo Pfennigstorf updated the commit message in patch set 2 02/13/17, 09:14
-
TYPO3com voted on patch set 1 V +1 02/13/17, 09:17 Completed build in 05m 34s on Mon, 13 Feb, 10:17 AM Test Summary: 56273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7988
-
TYPO3com voted on patch set 2 V +1 02/13/17, 09:19 Completed build in 05m 12s on Mon, 13 Feb, 10:19 AM Test Summary: 56273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7989
-
Helmut Hummel commented on patch set 2 CR -1 02/13/17, 13:56
what does "splat" mean? -
Cedric Ziel commented on patch set 2 02/13/17, 14:00
Reply
"splat" is the name of the operator that unpacks the array to arguments. (http://php.net/manual/en/migration56.new-features.php#migration56.new-features.splat) -
Helmut Hummel commented on patch set 2 CR 0 02/13/17, 14:25
ah, thanks. didn't know that the operator for argument unpacking has a name ^^ -
Helmut Hummel updated the commit message in patch set 3 02/13/17, 14:26
-
Helmut Hummel voted on patch set 3 CR +2 V +2 02/13/17, 14:26
-
TYPO3com voted on patch set 3 V +1 02/13/17, 14:33 Completed build in 06m 51s on Mon, 13 Feb, 03:33 PM Test Summary: 56273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8002
-
Gerrit merged patch set 3 02/13/17, 16:35