51662[BUGFIX] Fix broken svg flag
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1012
-
Josef Glatz uploaded patch set 1 02/13/17, 22:14
-
Markus Klein commented on patch set 1 CR -1 02/13/17, 22:18
This stems from an external resource, see bower and grunt. "region-flags" -
TYPO3com voted on patch set 1 V +1 02/13/17, 22:19 Completed build in 04m 40s on Mon, 13 Feb, 11:19 PM Test Summary: 56273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8019
-
Josef Glatz commented on patch set 1 02/13/17, 22:21
Yeah, I know. I didn't manually fixed them. It was fixed in the "region-flags" package. -
Josef Glatz commented on patch set 1 02/13/17, 22:23
...or the svgmin task had some troubles. If you take a like at the before after view in the issue you see that the flag is fixed -
Markus Klein commented on patch set 1 02/13/17, 22:23
Ah, I see. Please update the commit message to reflect that update of the external lib -
Josef Glatz commented on patch set 1 02/13/17, 22:28
hmm seems like it wasn't a update of the external lib. https://github.com/behdad/region-flags/blob/gh-pages/svg/VN.svg wasn't updated since 3 years. So I would strongly suspect, that svgmin did something bad a few month ago -
Josef Glatz uploaded patch set 2 02/14/17, 06:40
-
TYPO3com voted on patch set 2 V +1 02/14/17, 06:46 Completed build in 05m 28s on Tue, 14 Feb, 07:46 AM Test Summary: 56275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8029
-
Wouter Wolters voted on patch set 2 CR +1 V +1 02/14/17, 07:38
-
Markus Klein voted on patch set 2 CR +2 V +2 02/14/17, 09:41
-
Gerrit merged patch set 2 02/14/17, 09:41