Review TYPO3_7-6 Merged

51675[BUGFIX] Truncate long GIFBUILDER file names

Markus Klein CR +2 V +2 Easy +3 −0 updated 02/14/17, 15:43

Commit message

GIFBUILDER generates file names from serialized data from
the GIFBUILDER setup (typoscript).
This can result in too long file names when the GIFBUILDER
is called with many parameters and on filesystems with
a max filename/path length.

The comment of the function fileName() states that the filename
should be shortened to 100 chars, but this doesn't happen.

This patch introduces a simple substring to enforce this limit.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 34

  1. Markus Klein commented on patch set 1 02/14/17, 15:38

    Cherry Picked from branch master.
  2. Markus Klein voted on patch set 1 CR +2 V +2 02/14/17, 15:40

  3. Gerrit merged patch set 1 02/14/17, 15:40

  4. TYPO3com commented on patch set 1 02/14/17, 15:43 Completed build in 05m 07s on Tue, 14 Feb, 04:43 PM Test Summary: 38575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-713