51676[FEATURE] Allow overriding of image manipulation cropVariants
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Benni Mack +2
- Jasmina Ließmann +1
- Frans Saris +1
-
Verified V +2
- Helmut Hummel +2
- Jasmina Ließmann +1
- Frans Saris +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −1
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php+4 −4
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-79812-AllowOverridingCropVariantsForImageManipulation.rstnew+48 −0
Review log 1416
-
Stefan Froemken uploaded patch set 1 02/14/17, 16:00
-
TYPO3com voted on patch set 1 V +1 02/14/17, 16:05 Completed build in 05m 15s on Tue, 14 Feb, 05:05 PM Test Summary: 56277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8057
-
Wouter Wolters voted on patch set 1 CR +1 02/14/17, 16:06
-
Frans Saris commented on patch set 1 02/14/17, 17:57
This needs some documentation -
Josef Glatz voted on patch set 1 CR +1 02/18/17, 23:49
-
Frans Saris uploaded patch set 2 02/19/17, 13:34
-
Frans Saris voted on patch set 2 CR +1 V +1 02/19/17, 13:36
-
TYPO3com voted on patch set 2 V +1 02/19/17, 13:43 Completed build in 08m 53s on Sun, 19 Feb, 02:43 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8261
-
Helmut Hummel commented on patch set 2 02/20/17, 15:18
That is imho no feature, but a bugfix -
Frans Saris commented on patch set 2 02/21/17, 07:28
it's a bugfix that's needs feature rst file. So I made it a feature -
Benni Mack voted on patch set 2 CR +2 02/22/17, 19:30
-
Mona Muzaffar voted on patch set 2 V +1 02/23/17, 08:45
-
Helmut Hummel commented on patch set 2 CR -1 02/23/17, 14:38
on it -
Jasmina Ließmann voted on patch set 2 CR +1 V +1 02/23/17, 15:01
-
Helmut Hummel commented on patch set 2 CR +2 V +2 02/23/17, 15:03
Works great, thanks -
Gerrit merged patch set 2 02/23/17, 15:03