Review main Merged

51676[FEATURE] Allow overriding of image manipulation cropVariants

Stefan Froemken CR +2 V +2 Normal +54 −6 updated 02/23/17, 15:03

Commit message

It is not possible to change or override cropVariants via TSconfig
for sys_file_reference (e.g. for a specific user or page tree branch),
thus making the cropping functionality a pain for bigger sites.
Setting a FormEngine option as expected like
TCEFORM.sys_file_reference.crop.config.cropVariants.* does now work.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Frans Saris +1
  • Verified V +2
    • Helmut Hummel +2
    • Jasmina Ließmann +1
    • Frans Saris +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1416

  1. Stefan Froemken uploaded patch set 1 02/14/17, 16:00

  2. TYPO3com voted on patch set 1 V +1 02/14/17, 16:05 Completed build in 05m 15s on Tue, 14 Feb, 05:05 PM Test Summary: 56277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8057

  3. Wouter Wolters voted on patch set 1 CR +1 02/14/17, 16:06

  4. Frans Saris commented on patch set 1 02/14/17, 17:57

    This needs some documentation
  5. Josef Glatz voted on patch set 1 CR +1 02/18/17, 23:49

  6. Frans Saris uploaded patch set 2 02/19/17, 13:34

  7. Frans Saris voted on patch set 2 CR +1 V +1 02/19/17, 13:36

  8. TYPO3com voted on patch set 2 V +1 02/19/17, 13:43 Completed build in 08m 53s on Sun, 19 Feb, 02:43 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8261

  9. Helmut Hummel commented on patch set 2 02/20/17, 15:18

    That is imho no feature, but a bugfix
  10. Frans Saris commented on patch set 2 02/21/17, 07:28

    it's a bugfix that's needs feature rst file. So I made it a feature
  11. Benni Mack voted on patch set 2 CR +2 02/22/17, 19:30

  12. Mona Muzaffar voted on patch set 2 V +1 02/23/17, 08:45

  13. Helmut Hummel commented on patch set 2 CR -1 02/23/17, 14:38

    on it
  14. Jasmina Ließmann voted on patch set 2 CR +1 V +1 02/23/17, 15:01

  15. Helmut Hummel commented on patch set 2 CR +2 V +2 02/23/17, 15:03

    Works great, thanks
  16. Gerrit merged patch set 2 02/23/17, 15:03