Review main Abandoned

51689[BUGFIX] Automatically ignore unrecognised Fluid xmlns

Claus Due CR 0 V 0 Normal +68 −53 updated 02/20/17, 21:53

Commit message

This patch changes the namespace detection to include
all xmlns definitions rather than just those prefixed with
the typo3.org domain. Namespaces which are not prefixed
with the expected domain name automatically get added
to the list of ignored namespaces.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 67

  1. Claus Due uploaded patch set 1 02/14/17, 21:20

  2. TYPO3com voted on patch set 1 V +1 02/14/17, 21:25 Completed build in 05m 19s on Tue, 14 Feb, 10:25 PM Test Summary: 56277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8069

  3. Wouter Wolters voted on patch set 1 CR +1 02/14/17, 21:28

  4. Gerrit Mohrmann commented on patch set 1 CR -1 02/15/17, 00:00

    Are you sure that this class is involved? Have added a stack trace to the issue. With this patch I become the same exception.
  5. Claus Due commented on patch set 1 02/15/17, 01:27

    I don't mean to sound ungrateful, but I can't use the stack dump in this case. Not just because it's all on a single line, but also because the failure doesn't have anything to do with this class except indirectly. This class here extracts and adds namespaces - the error (most likely, I didn't scroll that far right...) comes from the parsing step which happens after this class hopefully did its work. You may want to read through the unit test data provider in this patch; it should explain what is possible and not - maybe your template falls into one of the "not supported" categories?
  6. Gerrit Mohrmann commented on patch set 1 02/15/17, 09:53

    If I remove the tags that leads to an excaption, all namespaces are gone in the output. Not only the fluid ones. So whats wrong with these template? https://github.com/georgringer/news/blob/master/Resources/Private/Templates/News/List.xml
  7. Claus Due abandoned the change 02/20/17, 21:53