Review main Merged

51691[BUGFIX] CKEditor: Avoid JS error when opening an existing link

Benni Mack CR +2 V +2 Easy +21 −7 updated 02/15/17, 18:38

Commit message

When opening an existing link by double-clicking on the
a tag element in CKEditor the popup should open, however
if no additional attributes are registered, JS throws an
error.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Frans Saris +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 02/15/17, 05:49

  2. TYPO3com voted on patch set 1 V +1 02/15/17, 05:54 Completed build in 04m 54s on Wed, 15 Feb, 06:54 AM Test Summary: 56277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8073

  3. Georg Ringer voted on patch set 1 CR +1 V +1 02/15/17, 07:15

  4. Wouter Wolters voted on patch set 1 CR +1 02/15/17, 07:42

  5. Frans Saris voted on patch set 1 CR +1 02/15/17, 08:26

  6. Wouter Wolters voted on patch set 1 CR +2 V +2 02/15/17, 18:38

  7. Gerrit merged patch set 1 02/15/17, 18:38