Review TYPO3_7-6 Merged

51694[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop()

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 02/15/17, 12:38

Commit message

PHP’s `array_pop()` requires its argument being passed as reference,
but the result of `array_keys()` is directly used.
The result of `array_keys()` is now stored into a variable which gets
passed to `array_pop()`.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 02/15/17, 12:21

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/15/17, 12:27 Completed build in 06m 09s on Wed, 15 Feb, 01:27 PM Test Summary: 38575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-716

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/15/17, 12:38

  4. Gerrit merged patch set 1 02/15/17, 12:38