Review main Merged

51704[BUGFIX] UriBuilder: Do not skip empty parameters

Markus Klein CR +2 V +2 Easy +14 −9 updated 02/16/17, 14:44

Commit message

This is not the job of the uri builder to decide this.
It must simply build an URL from all given parameters.

In general, empty parameters can be intended by a dev.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
    • Johannes Kasberger +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1215

  1. Markus Klein uploaded patch set 1 02/15/17, 15:55

  2. Markus Klein updated the commit message in patch set 2 02/15/17, 15:59

  3. Johannes Kasberger voted on patch set 2 CR +1 V +1 02/15/17, 15:59

  4. Josef Glatz voted on patch set 2 CR +1 02/15/17, 16:00

  5. TYPO3com voted on patch set 1 V -1 02/15/17, 16:00 Completed build in 05m 04s on Wed, 15 Feb, 05:00 PM Test Summary: 42 of 56277 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8089

  6. TYPO3com voted on patch set 2 V -1 02/15/17, 16:05 Completed build in 06m 15s on Wed, 15 Feb, 05:05 PM Test Summary: 42 of 56277 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8090

  7. Markus Klein uploaded patch set 3 02/15/17, 16:44

  8. TYPO3com voted on patch set 3 V +1 02/15/17, 16:50 Completed build in 06m 08s on Wed, 15 Feb, 05:50 PM Test Summary: 56277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8097

  9. Benni Mack voted on patch set 3 CR +1 02/15/17, 19:05

  10. Wouter Wolters voted on patch set 3 CR +1 02/15/17, 21:39

  11. Johannes Kasberger voted on patch set 3 CR +1 V +1 02/16/17, 10:10

  12. Josef Glatz voted on patch set 3 CR +1 02/16/17, 11:09

  13. Benni Mack voted on patch set 3 CR +2 V +2 02/16/17, 12:20

  14. Gerrit merged patch set 3 02/16/17, 14:44

  15. Benni Mack commented on patch set 4 02/16/17, 14:44

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 823e10534858c4b38fd57af3074b96c92f1b78ef