Review main Merged

51707[TASK] Add helper method to deprecate ViewHelper attributes

Frank Nägler CR +2 V +2 Normal +50 −2 updated 02/28/17, 12:18

Commit message

This patch introduce a new helper method for deprecations in ViewHelper
classes. The new method can detect the template path and log the path.

Review

  • Code review CR +2
    • Markus Klein +2
    • Johannes Kasberger +1
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Johannes Kasberger +1
    • Christian Kuhn +1
    • TYPO3 GmbH TYPO3com +1 CI

Files 3

Review log 2937

Show 912 earlier messages Hide the earlier messages
  1. Frank Nägler uploaded patch set 1 02/15/17, 17:46

  2. Frank Nägler uploaded patch set 2 02/15/17, 17:49

  3. TYPO3com voted on patch set 1 V -1 02/15/17, 17:53 Completed build in 07m 32s on Wed, 15 Feb, 06:53 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8106

  4. TYPO3com voted on patch set 2 V +1 02/15/17, 17:54 Completed build in 05m 25s on Wed, 15 Feb, 06:54 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8107

  5. Frank Nägler commented on patch set 2 CR -1 02/15/17, 18:50

    Hint from Claus: - that works for templates but won't report about partials and layouts related to the template - so it may report false positives, saying template contains problem when in fact partial does
  6. Frank Nägler voted on patch set 2 CR +1 V +1 02/16/17, 21:42

  7. Frank Nägler voted on patch set 2 CR -1 V 0 02/16/17, 21:42

  8. Frank Nägler uploaded patch set 3 02/27/17, 20:30

  9. TYPO3com voted on patch set 3 V +1 02/27/17, 20:38 Completed build in 08m 37s on Mon, 27 Feb, 09:38 PM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8710

  10. Markus Klein commented on patch set 3 02/27/17, 21:44

    GeneralUtility.php:4440

    this text is wrong by definition. a deprecated code MUST still work as expected, otherwise it's a breaking change.
  11. Frank Nägler commented on patch set 3 02/27/17, 21:48

    GeneralUtility.php:4440 Reply

    no, because it could be that the code do the right thing per default. but I agree, the message is misleading.
  12. Frank Nägler uploaded patch set 4 02/27/17, 21:48

  1. TYPO3com voted on patch set 4 V +1 02/27/17, 21:58 Completed build in 09m 47s on Mon, 27 Feb, 10:58 PM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8713

  2. Markus Klein commented on patch set 4 02/27/17, 22:06

    GeneralUtility.php:26

    I'm not sure about the place of the method. This line actually tells us that we have a cross-dependency on Fluid now in a "utility" class. What do you think about moving that method some class in the sysext:fluid?
  3. Frank Nägler commented on patch set 4 02/27/17, 22:22

    GeneralUtility.php:26 Reply

    because we have all deprecation method in this class, I am against a method in any other class. TYPO3Fluid is a dependency for the core, search for use statements found usages in nearly every sysext.
  4. Christian Kuhn commented on patch set 4 02/28/17, 09:17

    GeneralUtility.php:26 Reply

    actually, in this case, i'd do it as proposed by frank with that patch: i think the advantage of having all 3 depracation methods in one place is bigger than the slight collision with "static methods must not have deps" here. In this very case the dependency is even a method argument, and not a "makeInstance" of something within the method body ... thus, I'd say: do it as proposed.

    GeneralUtility.php:4424

    let's add some good comment here with a usage example and a hint on what would be actually looged.
  5. Frank Nägler uploaded patch set 5 02/28/17, 09:35

  6. Frank Nägler uploaded patch set 6 02/28/17, 09:39

  7. TYPO3com voted on patch set 5 V +1 02/28/17, 09:44 Completed build in 08m 34s on Tue, 28 Feb, 10:44 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8736

  8. TYPO3com voted on patch set 6 V +1 02/28/17, 09:47 Completed build in 07m 17s on Tue, 28 Feb, 10:47 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8737

  9. Markus Klein voted on patch set 6 CR +1 V +1 02/28/17, 09:53

  10. Markus Klein voted on patch set 6 CR 0 02/28/17, 09:55

  11. Frank Nägler uploaded patch set 7 02/28/17, 09:56

  12. Markus Klein voted on patch set 7 CR +1 V +1 02/28/17, 09:56

  13. Georg Ringer commented on patch set 6 02/28/17, 09:56

    GeneralUtility.php:4427

    automatically

    GeneralUtility.php:4428

    "is is" => "it is"

    GeneralUtility.php:4449

    add types

    TranslateViewHelper.php:134

    viewHelper
  14. Johannes Kasberger voted on patch set 7 CR +1 V +1 02/28/17, 09:57

  15. Frank Nägler voted on patch set 7 CR -2 02/28/17, 09:58

  16. Frank Nägler commented on patch set 6 02/28/17, 09:59

    GeneralUtility.php:4427 Reply

    Done

    GeneralUtility.php:4428 Reply

    Done
  17. Frank Nägler uploaded patch set 8 02/28/17, 09:59

  18. Frank Nägler voted on patch set 8 CR 0 02/28/17, 09:59

  19. TYPO3com voted on patch set 7 V +1 02/28/17, 10:04 Completed build in 08m 15s on Tue, 28 Feb, 11:04 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8738

  20. TYPO3com voted on patch set 8 V +1 02/28/17, 10:09 Completed build in 09m 39s on Tue, 28 Feb, 11:09 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8739

  21. Christian Kuhn commented on patch set 8 02/28/17, 10:20

    example output (i hacked the template to trigger this): 28-02-17 11:20: [typo3/sysext/backend/Resources/Private/Templates/ToolbarMenu/SystemInformation.html] The property "htmlEscape" has been marked as deprecated. Please wrap the view helper in <f:format.raw> if you want to disable HTML escaping, which is enabled by default now. Please check also your partial and layout files of this template
  22. Christian Kuhn commented on patch set 8 CR +1 V +1 02/28/17, 10:21

    like!
  23. Johannes Kasberger voted on patch set 8 CR +1 V +1 02/28/17, 12:16

  24. Markus Klein voted on patch set 8 CR +2 V +2 02/28/17, 12:17

  25. Gerrit merged patch set 8 02/28/17, 12:18