Review main Merged

51710[TASK] Make progress of tasks in scheduler more readable

Thomas Hohn CR +2 V +2 Easy +4 −1 updated 02/19/17, 21:19

Commit message

Currently it's hard to read the progress of tasks in the
scheduler due to the combination of blue, white and light
grey. Change of background color for progress from f5f5f5
to dedede makes it more readable.

Review

  • Code review CR +2
    • Sascha Egerer +2
    • Tomas Norre Mikkelsen +1
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Philipp Gampe +1
  • Verified V +2
    • Sascha Egerer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1723

  1. Thomas Hohn uploaded patch set 1 02/15/17, 20:45

  2. TYPO3com voted on patch set 1 V +1 02/15/17, 20:50 Completed build in 04m 20s on Wed, 15 Feb, 09:50 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8117

  3. Thomas Hohn updated the commit message in patch set 2 02/15/17, 20:50

  4. Thomas Hohn updated the commit message in patch set 3 02/15/17, 20:53

  5. TYPO3com voted on patch set 2 V +1 02/15/17, 20:55 Completed build in 05m 28s on Wed, 15 Feb, 09:55 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8118

  6. TYPO3com voted on patch set 3 V +1 02/15/17, 20:58 Completed build in 05m 09s on Wed, 15 Feb, 09:58 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8119

  7. Claus Due voted on patch set 3 CR +1 02/15/17, 21:28

  8. Daniel Goerz commented on patch set 3 02/15/17, 21:55

    Isn't that file generated by the grunt build?
  9. Georg Ringer commented on patch set 3 CR -1 02/16/17, 05:43

    Please adopt the according less file
  10. Thomas Hohn uploaded patch set 4 02/16/17, 08:32

  11. TYPO3com voted on patch set 4 V +1 02/16/17, 08:36 Completed build in 04m 48s on Thu, 16 Feb, 09:36 AM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8131

  12. Wouter Wolters commented on patch set 4 CR -1 02/16/17, 08:58

    Now the compiled CSS file is missing ;)
  13. Thomas Hohn uploaded patch set 5 02/16/17, 10:06

  14. TYPO3com voted on patch set 5 V +1 02/16/17, 10:11 Completed build in 04m 47s on Thu, 16 Feb, 11:11 AM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8134

  15. Wouter Wolters commented on patch set 5 CR -1 02/16/17, 10:25

    Now it includes too much, the grunt task has a tool postcss that removes the extra change here. Please use "grunt css" to compile the css file.
  16. Thomas Hohn uploaded patch set 6 02/16/17, 10:48

  17. TYPO3com voted on patch set 6 V +1 02/16/17, 10:53 Completed build in 05m 10s on Thu, 16 Feb, 11:53 AM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8135

  18. Tomas Norre Mikkelsen voted on patch set 6 CR +1 02/16/17, 11:11

  19. Philipp Gampe voted on patch set 6 CR +1 02/16/17, 14:55

  20. Christian Kuhn voted on patch set 6 CR +1 V +1 02/17/17, 01:06

  21. Wouter Wolters voted on patch set 6 CR +1 02/17/17, 07:31

  22. Sascha Egerer voted on patch set 6 CR +2 V +2 02/19/17, 21:19

  23. Gerrit merged patch set 6 02/19/17, 21:19