Review main Merged

51711[TASK] Update Fluid dependency to version 2.3.1

Claus Due CR +2 V +2 Normal +44 −7 updated 02/22/17, 23:35

Commit message

Solves three issues:

* Namespace declaration output in templates without sections
* Potential error from unexpected input argument in sanitizePath
* Rendering of new HeaderAssets / FooterAssets sections in
   uncompiled templates.

Adds two Fluid features:

* Namespace detection is now in sync with TYPO3 CMS.
* Escaping modifier `{escaping off}` now supported.

And allows the removal of two custom Fluid integrations
contained in TYPO3 which are now included in Fluid.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1824

  1. Claus Due uploaded patch set 1 02/15/17, 21:22

  2. TYPO3com voted on patch set 1 V +1 02/15/17, 21:26 Completed build in 04m 50s on Wed, 15 Feb, 10:26 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8120

  3. Georg Ringer commented on patch set 1 CR +1 V +1 02/16/17, 06:22

    should a rst added for one of the changes?
  4. Wouter Wolters voted on patch set 1 CR +1 02/17/17, 10:28

  5. Benni Mack commented on patch set 1 02/21/17, 07:58

    This is mainly a bugfix release (so "Task" is fine), I think an "Important.rst" would be good though as they are mainly there to solve issues.
  6. Gerrit Mohrmann commented on patch set 1 CR +1 V +1 02/21/17, 13:59

    Issue https://forge.typo3.org/issues/79811 solved with this patch
  7. Claus Due commented on patch set 1 02/21/17, 23:27

    Gerrit just ate a huge reply (not you, Morhmann - you get a "thank you!" for confirming the solution!). God damn this logout-destroys-comment-field issue, it's seriously such a friggin time waster! Short version of previous comment: I'll write an RST when we possibly have 2.3.1 which includes https://github.com/TYPO3/Fluid/pull/269. That patch solves an issue with new HeaderAssets / FooterAssets sections in which they fail to output until the template is compiled (in general, it fixes repeatedly calling renderSection() on the same View instance before template is compiled). If you can review/confirm you're welcome to merge - if not, I'll arrange testing/merging with Marc some time tomorrow and hopefully make 2.3.1 right after that.
  8. Claus Due commented on patch set 1 02/21/17, 23:28

    (that last comment was for you, Benni - forgot to @ you)
  9. Claus Due uploaded patch set 2 02/22/17, 14:08

  10. TYPO3com voted on patch set 2 V +1 02/22/17, 14:17 Completed build in 09m 44s on Wed, 22 Feb, 03:17 PM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8371

  11. Claus Due uploaded patch set 3 02/22/17, 14:18

  12. Claus Due commented on patch set 3 02/22/17, 14:19

    Bumpted to 2.3.1 and "important" RST added. Note, this patch will be followed up by another patch requesting the removal of the two classes mentioned in the RST (as well as some related removals of redundant code from TemplatePaths and RenderingContext).
  13. TYPO3com voted on patch set 3 V +1 02/22/17, 14:24 Completed build in 05m 51s on Wed, 22 Feb, 03:24 PM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8372

  14. Claus Due updated the commit message in patch set 4 02/22/17, 14:27

  15. Claus Due commented on patch set 4 02/22/17, 14:27

    Just a minor improvement to the commit message wording in the features section.
  16. Claus Due updated the commit message in patch set 5 02/22/17, 14:28

  17. TYPO3com voted on patch set 4 V +1 02/22/17, 14:35 Completed build in 07m 57s on Wed, 22 Feb, 03:35 PM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8373

  18. TYPO3com voted on patch set 5 V +1 02/22/17, 14:37 Completed build in 08m 45s on Wed, 22 Feb, 03:37 PM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8374

  19. Benni Mack updated the commit message in patch set 6 02/22/17, 17:53

  20. TYPO3com voted on patch set 6 V +1 02/22/17, 18:00 Completed build in 06m 45s on Wed, 22 Feb, 07:00 PM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8379

  21. Christian Kuhn voted on patch set 6 CR +1 V +1 02/22/17, 18:36

  22. Benni Mack voted on patch set 6 CR +2 V +2 02/22/17, 18:38

  23. Gerrit merged patch set 6 02/22/17, 18:38

  24. Claus Due commented on patch set 5 02/22/17, 23:35

    Thanks for the attention guys :)