Review TYPO3_7-6 Merged

51718[BUGFIX] UriBuilder: Do not skip empty parameters

Benni Mack CR +2 V +2 Easy +14 −9 updated 02/16/17, 14:52

Commit message

This is not the job of the uri builder to decide this.
It must simply build an URL from all given parameters.

In general, empty parameters can be intended by a dev.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Benni Mack commented on patch set 1 02/16/17, 14:44

    Cherry Picked from branch master.
  2. Benni Mack commented on patch set 1 CR +2 V +2 02/16/17, 14:44

    waiting for tests
  3. TYPO3com voted on patch set 1 V +1 02/16/17, 14:52 Completed build in 07m 29s on Thu, 16 Feb, 03:51 PM Test Summary: 38575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-720

  4. Gerrit merged patch set 1 02/16/17, 14:52