Review main Merged

51723[CLEANUP] Remove superfluous initialization of UriBuilder

Sascha Egerer CR +2 V +2 Easy +0 −2 updated 02/16/17, 23:34

Commit message

The UriBuilder initialization has been added in
f5dd76ca41f70ea7ab22a2aeb1291aabefc95232 but it is not used
anywhere

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Sascha Egerer uploaded patch set 1 02/16/17, 21:24

  2. Sascha Egerer updated the commit message in patch set 2 02/16/17, 21:26

  3. TYPO3com voted on patch set 1 V -1 02/16/17, 21:29 Completed build in 05m 52s on Thu, 16 Feb, 10:29 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8167

  4. TYPO3com voted on patch set 2 V -1 02/16/17, 21:31 Completed build in 05m 41s on Thu, 16 Feb, 10:31 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8168

  5. Sascha Egerer uploaded patch set 3 02/16/17, 21:40

  6. Thomas Hohn voted on patch set 3 CR +1 02/16/17, 21:46

  7. TYPO3com voted on patch set 3 V +1 02/16/17, 21:46 Completed build in 06m 23s on Thu, 16 Feb, 10:46 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8171

  8. Christian Kuhn commented on patch set 3 CR +2 V +2 02/16/17, 23:33

    no-brainer, imho: class extends from nothing, nothing extends class.
  9. Gerrit merged patch set 3 02/16/17, 23:34