Review main Merged

51735[BUGFIX] Check simplexml return type in ImageInfo

Tim Spiekerkötter CR +2 V +2 Easy +45 −2 updated 11/28/17, 11:14

Commit message

According to the php documentation[1] simplexml_load_file may return
false on failure. We need to check for this before we call the
attributes method on the expected SimpleXMLElement.

[1] http://php.net/manual/en/function.simplexml-load-file.php

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1521

  1. Tim Spiekerkötter uploaded patch set 1 02/17/17, 12:23

  2. TYPO3com voted on patch set 1 V -1 02/17/17, 12:28 Completed build in 04m 55s on Fri, 17 Feb, 01:28 PM Test Summary: 56295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8207

  3. Tim Spiekerkötter uploaded patch set 2 02/17/17, 12:45

  4. TYPO3com voted on patch set 2 V +1 02/17/17, 12:50 Completed build in 04m 40s on Fri, 17 Feb, 01:50 PM Test Summary: 56295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8208

  5. Tim Lochmüller voted on patch set 2 CR +1 02/17/17, 13:02

  6. Carsten Biebricher voted on patch set 2 CR +1 02/17/17, 13:04

  7. Mathias Brodala commented on patch set 2 CR -1 02/17/17, 13:54

    I'd strongly recommend reporting the warning and not silently swallow it.

    ImageInfo.php:95

  8. Tim Spiekerkötter rebased onto patch set 3 07/14/17, 20:36

  9. Christian Kuhn commented on patch set 3 07/14/17, 20:42

    should now be "master, 8.7" i guess.
  10. Christian Kuhn commented on patch set 3 CR -1 07/14/17, 20:43

    minor issues could be fixed.

    ImageInfoTest.php:26

    shouldn't be needed, vfsStream() is a require-dev dependency of core.
  11. TYPO3com voted on patch set 3 V -1 07/14/17, 20:53 Completed build in 17m 14s on Fri, 14 Jul, 10:53 PM Test Summary: 2 of 19146 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13196

  12. Jörg Bösche uploaded patch set 4 07/20/17, 10:56

  13. TYPO3com voted on patch set 4 V -1 07/20/17, 11:05 Completed build in 09m 05s on Thu, 20 Jul, 01:05 PM Test Summary: 935 of 57247 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13342

  14. TYPO3com commented on patch set 4 07/20/17, 11:11 Completed build in 24m 22s on Thu, 20 Jul, 01:11 PM Test Summary: 746 of 57247 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13342

  15. Jörg Bösche uploaded patch set 5 07/20/17, 11:17

  16. Jörg Bösche commented on patch set 4 07/20/17, 11:20

    I had to remove the GeneralUtility::purgeInstances(). A separate patch must clean up the dependencies in the UnitTests. After that, we can use GeneralUtility::purgeInstances() in tearDown() and no other tests will fail.
  17. TYPO3com voted on patch set 5 V +1 07/20/17, 11:27 Completed build in 10m 09s on Thu, 20 Jul, 01:27 PM Test Summary: 56883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13343

  18. Susi Moog voted on patch set 5 CR +1 V +1 11/28/17, 08:37

  19. Christian Kuhn voted on patch set 5 CR +2 V +2 11/28/17, 11:13

  20. Gerrit merged patch set 5 11/28/17, 11:14

  21. Christian Kuhn commented on patch set 6 11/28/17, 11:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 2cd9b38d21d69632efa419c58c58981256d4a6e9