Review main Merged

51742[CLEANUP] Ensure variables initalized and fix code smell

Sascha Egerer CR +2 V +2 Normal +73 −42 updated 02/23/17, 14:02

Commit message

* Ensure that variables are correctly initalized.
* Fix some php docs.
* Initalizes for loop iterator variables before the loop if they are
  also used after the for loop is finished.
* Remove superfluous function arguments.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Christer V +1
  • Verified V +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • TYPO3com +1 CI

Issues 1

Files 23

Show 3 more files

Review log 810

  1. Sascha Egerer uploaded patch set 1 02/18/17, 16:02

  2. TYPO3com voted on patch set 1 V +1 02/18/17, 16:16 Completed build in 14m 52s on Sat, 18 Feb, 05:16 PM Test Summary: 56365 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8223

  3. Johannes Goslar voted on patch set 1 CR +1 02/23/17, 08:39

  4. Thomas Hohn commented on patch set 1 CR -1 02/23/17, 09:42

    I'll do a testing of this one
  5. Thomas Hohn updated the commit message in patch set 2 02/23/17, 10:55

  6. Thomas Hohn voted on patch set 2 CR +1 V +1 02/23/17, 10:55

  7. TYPO3com voted on patch set 2 V +1 02/23/17, 11:01 Completed build in 05m 46s on Thu, 23 Feb, 12:01 PM Test Summary: 56409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8392

  8. Christer V voted on patch set 2 CR +1 02/23/17, 11:25

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 02/23/17, 14:02

  10. Gerrit merged patch set 2 02/23/17, 14:02