51742[CLEANUP] Ensure variables initalized and fix code smell
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Thomas Hohn +1
- Christer V +1
-
Verified V +2
- Christian Kuhn +2
- Thomas Hohn +1
- TYPO3com +1 CI
Issues 1
Files 23
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+10 −5
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −0
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+3 −0
- typo3/sysext/core/Classes/Controller/CommandLineController.php+1 −0
- typo3/sysext/core/Classes/Database/QueryGenerator.php+11 −6
- typo3/sysext/core/Classes/Database/QueryView.php+1 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −4
- typo3/sysext/core/Classes/ExtDirect/ExtDirectRouter.php+14 −13
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+1 −0
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+2 −1
- typo3/sysext/core/Classes/Http/Response.php+1 −1
- typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.php+1 −1
- typo3/sysext/core/Classes/Localization/LanguageStore.php+1 −1
- typo3/sysext/core/Classes/Package/MetaData/PackageConstraint.php+12 −0
- typo3/sysext/core/Classes/Service/DependencyOrderingService.php+1 −1
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+1 −0
- typo3/sysext/core/Classes/TypoScript/ConfigurationForm.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/CommandUtility.php+2 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+2 −3
Review log 810
-
Sascha Egerer uploaded patch set 1 02/18/17, 16:02
-
TYPO3com voted on patch set 1 V +1 02/18/17, 16:16 Completed build in 14m 52s on Sat, 18 Feb, 05:16 PM Test Summary: 56365 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8223
-
Johannes Goslar voted on patch set 1 CR +1 02/23/17, 08:39
-
Thomas Hohn commented on patch set 1 CR -1 02/23/17, 09:42
I'll do a testing of this one -
Thomas Hohn updated the commit message in patch set 2 02/23/17, 10:55
-
Thomas Hohn voted on patch set 2 CR +1 V +1 02/23/17, 10:55
-
TYPO3com voted on patch set 2 V +1 02/23/17, 11:01 Completed build in 05m 46s on Thu, 23 Feb, 12:01 PM Test Summary: 56409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8392
-
Christer V voted on patch set 2 CR +1 02/23/17, 11:25
-
Christian Kuhn voted on patch set 2 CR +2 V +2 02/23/17, 14:02
-
Gerrit merged patch set 2 02/23/17, 14:02