Review main Merged

51756[BUGFIX] Use correct check to find site root pages

Georg Ringer CR +2 V +2 Easy +3 −2 updated 02/19/17, 20:29

Commit message

The change #79857 introduced a wrong check to find the
site root pages. Instead of checking pid == 0, the field
is_siteroot must be used.

Review

  • Code review CR +2
    • Sascha Egerer +2
    • Josef Glatz +1
    • Thomas Hohn +1
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Sascha Egerer +2
    • Josef Glatz +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Georg Ringer uploaded patch set 1 02/19/17, 17:49

  2. TYPO3com voted on patch set 1 V +1 02/19/17, 17:56 Completed build in 06m 25s on Sun, 19 Feb, 06:55 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8266

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 02/19/17, 18:02

  4. Markus Klein commented on patch set 1 02/19/17, 19:14

    AbstractTreeView.php:692

    not needed, we are in boolean context already
  5. Markus Klein commented on patch set 2 02/19/17, 19:14

    Published edit on patch set 1.
  6. Andreas Kienast voted on patch set 2 CR +1 V +1 02/19/17, 19:15

  7. Markus Klein voted on patch set 2 CR +1 02/19/17, 19:16

  8. TYPO3com voted on patch set 2 V +1 02/19/17, 19:22 Completed build in 08m 15s on Sun, 19 Feb, 08:22 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8272

  9. Thomas Hohn voted on patch set 2 CR +1 02/19/17, 19:46

  10. Sascha Egerer voted on patch set 2 CR +2 V +2 02/19/17, 20:01

  11. Josef Glatz voted on patch set 2 CR +1 V +1 02/19/17, 20:19

  12. Gerrit merged patch set 2 02/19/17, 20:29