51759[BUGFIX] Add missing break statement in switch case
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Thomas Hohn +1
- Mona Muzaffar +1
-
Verified V +2
- Christian Kuhn +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1317
-
Sascha Egerer uploaded patch set 1 02/19/17, 19:45
-
Thomas Hohn voted on patch set 1 CR +1 02/19/17, 19:47
-
TYPO3com voted on patch set 1 V +1 02/19/17, 19:51 Completed build in 06m 19s on Sun, 19 Feb, 08:51 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8273
-
Thomas Hohn commented on patch set 1 CR 0 02/19/17, 19:57
-
Josef Glatz updated the commit message in patch set 2 02/19/17, 20:20
-
Josef Glatz commented on patch set 2 CR -1 02/19/17, 20:23
Afaik, there should be no empty line between @params and @return. I think you're right @Thomas. -
TYPO3com voted on patch set 2 V +1 02/19/17, 20:28 Completed build in 07m 36s on Sun, 19 Feb, 09:28 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8274
-
Sascha Egerer uploaded patch set 3 02/19/17, 20:43
-
Sascha Egerer updated the commit message in patch set 4 02/19/17, 20:44
-
TYPO3com voted on patch set 3 V +1 02/19/17, 20:50 Completed build in 07m 36s on Sun, 19 Feb, 09:50 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8279
-
TYPO3com voted on patch set 4 V +1 02/19/17, 20:53 Completed build in 09m 33s on Sun, 19 Feb, 09:53 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8280
-
Thomas Hohn commented on patch set 4 02/20/17, 06:44
TcaRecordTitle.php:213Isn't there a missing '*' here? -
Andreas Kienast commented on patch set 4 02/20/17, 07:12
TcaRecordTitle.php:213ReplyNope, we do not have an empty line between @param and @return -
Mona Muzaffar voted on patch set 4 CR +1 02/20/17, 08:19
-
Thomas Hohn commented on patch set 4 CR +1 02/20/17, 08:46
TcaRecordTitle.php:213ReplyMy bad - compared it to one of the previous versions where there suddenly was a lot of empty lines... -
Christian Kuhn voted on patch set 4 CR +2 V +2 02/20/17, 19:36
-
Gerrit merged patch set 4 02/20/17, 19:36
TcaRecordTitle.php