Review main Merged

51761[BUGFIX] InvalidXmlFileException for invalid locallang.xml

Sascha Egerer CR +2 V +2 Easy +6 −0 updated 02/25/17, 14:52

Commit message

Throw a meaningful InvalidXmlFileException when an invalid locallang.xml
file is detected.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Thomas Hohn +1
    • Stephan Großberndt +1
    • Faton Haliti +1
    • Anders Kostending +1
  • Verified V +2
    • Helmut Hummel +2
    • Stephan Großberndt +1
    • Faton Haliti +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2331

Show 56 earlier messages
  1. Sascha Egerer uploaded patch set 1 02/19/17, 20:36

  2. TYPO3com voted on patch set 1 V +1 02/19/17, 20:52 Completed build in 15m 46s on Sun, 19 Feb, 09:52 PM Test Summary: 56364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8278

  3. Stephan Großberndt commented on patch set 1 CR -1 02/20/17, 08:35

    Silent ignore is not a good idea in my opinion. It's an error in an extension so the author needs to change that. Rather make an explicit message stating which file could not be parsed due to invalid format.
  4. Christian Kuhn commented on patch set 1 02/20/17, 20:01

    maybe throw exception?
  5. Sascha Egerer commented on patch set 1 02/20/17, 20:23

    Yes, I've something pending. Needs a. It refactoring but not sure if it is possible without a breaking change in the abstract class. Would that be ok or do we need a non breaking solution?
  6. Faton Haliti uploaded patch set 2 02/24/17, 12:37

  1. TYPO3com voted on patch set 2 V -1 02/24/17, 12:49 Completed build in 11m 57s on Fri, 24 Feb, 01:49 PM Test Summary: 1 of 57501 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8483

  2. Faton Haliti uploaded patch set 3 02/24/17, 13:02

  3. TYPO3com voted on patch set 3 V -1 02/24/17, 13:10 Completed build in 07m 05s on Fri, 24 Feb, 02:10 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8486

  4. Stephan Großberndt commented on patch set 4 02/24/17, 14:05

    Published edit on patch set 3.
  5. Stephan Großberndt commented on patch set 4 02/24/17, 14:07

    LocallangXmlParser.php:181

    I am still uncertain about the current patch state, maybe the invalid file should be caught here instead?
  6. TYPO3com voted on patch set 4 V -1 02/24/17, 14:24 Completed build in 18m 37s on Fri, 24 Feb, 03:24 PM Test Summary: 1 of 57501 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8496

  7. Faton Haliti uploaded patch set 5 02/24/17, 18:21

  8. Faton Haliti commented on patch set 5 02/24/17, 18:22

    With this path we catch also the invalid file
  9. TYPO3com voted on patch set 5 V -1 02/24/17, 18:31 Completed build in 10m 50s on Fri, 24 Feb, 07:31 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8516

  10. Anders Kostending voted on patch set 5 CR +1 02/25/17, 08:49

  11. Helmut Hummel uploaded patch set 6 02/25/17, 09:14

  12. TYPO3com voted on patch set 6 V +1 02/25/17, 09:21 Completed build in 07m 37s on Sat, 25 Feb, 10:21 AM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8534

  13. Stephan Großberndt commented on patch set 6 CR -1 02/25/17, 09:36

    On it

    LocallangXmlParser.php:79

    Does this costly reflection check really make sense? $root is a SimpleXMLElement, so $bodyOfFileTag can only be null or a SimpleXMLElement itself.
  14. Stephan Großberndt commented on patch set 7 02/25/17, 11:21

    Published edit on patch set 6.
  15. Stephan Großberndt commented on patch set 8 02/25/17, 11:22

    Published edit on patch set 7.
  16. Stephan Großberndt voted on patch set 8 CR +1 V +1 02/25/17, 11:23

  17. TYPO3com voted on patch set 7 V -1 02/25/17, 11:32 Completed build in 11m 10s on Sat, 25 Feb, 12:32 PM Test Summary: 57507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8545

  18. Thomas Hohn voted on patch set 8 CR +1 02/25/17, 11:33

  19. Anders Kostending voted on patch set 8 CR +1 02/25/17, 11:36

  20. TYPO3com voted on patch set 8 V +1 02/25/17, 11:37 Completed build in 14m 53s on Sat, 25 Feb, 12:37 PM Test Summary: 57507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8546

  21. Stephan Großberndt commented on patch set 8 02/25/17, 11:40

  22. Faton Haliti voted on patch set 8 CR +1 V +1 02/25/17, 11:43

  23. Helmut Hummel voted on patch set 8 CR +2 V +2 02/25/17, 14:51

  24. Gerrit merged patch set 8 02/25/17, 14:51

  25. Helmut Hummel commented on patch set 9 02/25/17, 14:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit df91d14a9a022c93be74cee053c166d3fc818401