Review main Merged

51772[BUGFIX] Install Tool configuration parser must handle nested config

Markus Klein CR +2 V +2 Hard +388 −207 updated 02/20/17, 18:05

Commit message

Since TYPO3_CONF_VARS may contain nested arrays and the array keys
for those subarrays may collide with first-level citizens (e.g. BE)
the current description parsing (parsing of PHP source code file)
fail hard for those cases.
The problem is not solvable without writing a dedicated full PHP parser
in order to have proper notion of nesting levels.
For this reason the regex-based parsing is completely removed and a
new and dedicated file for the option descriptions is introduced,
which stores the description into a PHP array.

This frees us from the buggy PHP code parsing with regex and enables us
in the future to enhance this array with more information.
(e.g. extract data type into a dedicated subarray element)

Review

  • Code review CR +2
    • Georg Ringer +2
    • Nicole Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 914

  1. Markus Klein uploaded patch set 1 02/20/17, 13:30

  2. Markus Klein commented on patch set 1 CR -1 V -1 02/20/17, 13:32

    one more thing ;-)
  3. TYPO3com voted on patch set 1 V +1 02/20/17, 13:36 Completed build in 06m 26s on Mon, 20 Feb, 02:36 PM Test Summary: 56376 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8299

  4. Markus Klein uploaded patch set 2 02/20/17, 16:52

  5. TYPO3com voted on patch set 2 V +1 02/20/17, 16:58 Completed build in 05m 46s on Mon, 20 Feb, 05:58 PM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8306

  6. Markus Klein uploaded patch set 3 02/20/17, 16:59

  7. Nicole Hummel commented on patch set 3 02/20/17, 17:06

    I don't get that sentence here
  8. TYPO3com voted on patch set 3 V +1 02/20/17, 17:13 Completed build in 13m 23s on Mon, 20 Feb, 06:13 PM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8307

  9. Markus Klein updated the commit message in patch set 4 02/20/17, 17:15

  10. Nicole Hummel voted on patch set 4 CR +1 V +1 02/20/17, 17:21

  11. TYPO3com voted on patch set 4 V -1 02/20/17, 17:24 Completed build in 08m 12s on Mon, 20 Feb, 06:24 PM Test Summary: 2 of 56381 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8309

  12. TYPO3com voted on patch set 4 V +1 02/20/17, 17:46 Completed build in 38m 35s on Mon, 20 Feb, 06:46 PM Test Summary: 56381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8309

  13. Georg Ringer voted on patch set 4 CR +2 V +2 02/20/17, 18:05

  14. Gerrit merged patch set 4 02/20/17, 18:05