51788[TASK] Extract CKEditor configuration into separate class
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 46
-
Benni Mack uploaded patch set 1 02/22/17, 05:30
-
TYPO3com voted on patch set 1 V -1 02/22/17, 05:40 Completed build in 09m 22s on Wed, 22 Feb, 06:40 AM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8352
-
Benni Mack uploaded patch set 2 02/22/17, 05:45
-
TYPO3com voted on patch set 2 V +1 02/22/17, 05:51 Completed build in 06m 06s on Wed, 22 Feb, 06:51 AM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8354
-
Christian Kuhn commented on patch set 2 CR -2 02/22/17, 07:41
Quite frankly, I'm not a fan: This is the opposite of what I did to the htmlarea where I integrated all the config and init stuff into the FormEngine Element. A LOT of the pain we had with htmlarea came from the fact that the extension was created in a way that it was somehow possible to use it apart from the formEngine construct. This always broke, pathes were wrong, context was different that thought, all stuff like that. At the moment we have the "fetch configuration" class which was only built because the data handler needs it, and that class has a todo "get rid of me again" attached to it already. This patch now creates a second class that does a similar thing for rendering details. This is not the way to go: Data preparation belongs to data providers, rendering to elements in FormEngine. There shouldn't be something 're-usable' in between. With rtehtmlarea i actively broke the "not in formEngine" context in 7.6 with this reasoning. I see only two options if something wants to fire a ckeditor: * Use the third party lib natively without further core support * Use formEngine RichTextElement together with a data provider which prepares the configuration Please do NOT inject something in between. -
Christian Kuhn abandoned the change 03/01/17, 11:03
not needed anymore.