Review main Merged

51791[BUGFIX] Fix parameter type in BackendModuleRequestHandler

Markus Hölzle CR +2 V +2 Easy +2 −1 updated 02/27/17, 05:37

Commit message

The function
\TYPO3\CMS\Core\Authentication\BackendUserAuthentication
->getPagePermsClause accepts only an integer value as parameter,
but a boolean value is given in
TYPO3\CMS\Backend\Http\BackendModuleRequestHandler->dispatchModule

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Markus Hölzle uploaded patch set 1 02/22/17, 08:41

  2. TYPO3com voted on patch set 1 V +1 02/22/17, 08:46 Completed build in 05m 00s on Wed, 22 Feb, 09:46 AM Test Summary: 56387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8358

  3. Mona Muzaffar voted on patch set 1 CR +1 02/22/17, 12:50

  4. Tymoteusz Motylewski commented on patch set 1 02/22/17, 21:27

    BackendModuleRequestHandler.php:152

    even better it could be \TYPO3\CMS\Core\Type\Bitmask\Permission::PAGE_SHOW
  5. Markus Hölzle uploaded patch set 2 02/23/17, 08:43

  6. TYPO3com voted on patch set 2 V -1 02/23/17, 08:51 Completed build in 07m 24s on Thu, 23 Feb, 09:51 AM Test Summary: 2 of 56411 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8386

  7. TYPO3com voted on patch set 2 V +1 02/23/17, 10:14 Completed build in 1h 37m 59s on Thu, 23 Feb, 11:14 AM Test Summary: 56411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8386

  8. Morton Jonuschat voted on patch set 2 CR +1 V +1 02/26/17, 22:04

  9. Wouter Wolters voted on patch set 2 CR +2 V +2 02/26/17, 22:05

  10. Gerrit merged patch set 2 02/26/17, 22:05

  11. Benni Mack commented on patch set 3 02/27/17, 05:35

    This should be backported to 7.6
  12. Benni Mack commented on patch set 3 02/27/17, 05:37