Review main Merged

51799[BUGFIX] Implement connection timeout option for Redis backend

Arno Schoon CR +2 V +2 Normal +54 −2 updated 02/28/17, 14:43

Commit message

Allow an option for connectionTimeout to be set for the Redis cache backend

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Richard Haeser +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1518

  1. Arno Schoon uploaded patch set 1 02/23/17, 09:42

  2. TYPO3com voted on patch set 1 V -1 02/23/17, 09:48 Completed build in 06m 16s on Thu, 23 Feb, 10:48 AM Test Summary: 56409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8389

  3. Arno Schoon uploaded patch set 2 02/23/17, 11:30

  4. Arno Schoon commented on patch set 2 02/23/17, 11:32

    Updated the duplicate exception code 1289679154 in file: sysext/core/Classes/Cache/Backend/RedisBackend.php (this was causing the build to fail). Should these codes be documented somewhere?
  5. TYPO3com voted on patch set 2 V +1 02/23/17, 11:37 Completed build in 06m 58s on Thu, 23 Feb, 12:37 PM Test Summary: 56409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8395

  6. Josef Glatz commented on patch set 2 02/23/17, 11:42

    Is really a BUGFIX. It feels more like a [TASK]. And we have to extend the API manual on github, if this patch get's merged
  7. Christian Kuhn commented on patch set 2 CR -1 02/23/17, 13:01

    RedisBackend.php:130

    shouldn't we default to some sane value? trying to connect with unlimited and waiting for php max_exec_time doesn't seem too clever to me. imho, if connecting to redis takes longer than a couple of milliseconds, that would be not acceptable in production. setting 1 second as connect timeout should be way more than enough, i guess.

    RedisBackend.php:299

    add unit tests for both exceptions, please.
  8. Arno Schoon commented on patch set 2 02/23/17, 18:59

    I agree we should default to something sensible, but what should that value be? I added this option so that's for a developer to decide. The default is set to `0` to follow the default of PHPRedis and not break existing setups. We could go with one second (which is still quite long), it prevents the CMS from waiting indefinitely but it's still long enough to keep the possible impact of this change low.
  9. Arno Schoon commented on patch set 2 02/23/17, 19:02

    > Is really a BUGFIX. It feels more like a [TASK]. And we have to > extend the API manual on github, if this patch get's merged Marking this as a task didn't really feel right considering the impact on our systems. But for TYPO3 as a product you might be right. With the next Patch Set I'll change it ;)
  10. Richard Haeser commented on patch set 2 02/23/17, 19:19

    > Is really a BUGFIX. It feels more like a [TASK]. And we have to > extend the API manual on github, if this patch get's merged An existing function that can break your website, seems a bug to me. By adding an option might suggest that it is an task, but I personally think this is a rather late discovered bug.
  11. Richard Haeser commented on patch set 2 02/23/17, 19:22

    > Is really a BUGFIX. It feels more like a [TASK]. And we have to > extend the API manual on github, if this patch get's merged Of course the API manual should be extended and tests should be added, but thats only meaningful if the main solution is good.
  12. Arno Schoon uploaded patch set 3 02/23/17, 20:48

  13. TYPO3com voted on patch set 3 V +1 02/23/17, 20:59 Completed build in 10m 37s on Thu, 23 Feb, 09:59 PM Test Summary: 56468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8433

  14. Georg Ringer voted on patch set 3 CR +1 V +1 02/27/17, 05:10

  15. Josef Glatz voted on patch set 3 CR +1 02/27/17, 06:08

  16. Richard Haeser voted on patch set 3 CR +1 V +1 02/28/17, 09:15

  17. Christian Kuhn voted on patch set 3 CR +2 V +2 02/28/17, 14:43

  18. Gerrit merged patch set 3 02/28/17, 14:43