Review main Merged

51808[BUGFIX] Use correct check in search if list module is available

Georg Ringer CR +2 V +2 Easy +19 −15 updated 05/12/17, 10:46

Commit message

The check if the list module is available for the user must be
extended to check for false as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 911

  1. Georg Ringer uploaded patch set 1 02/23/17, 18:26

  2. TYPO3com voted on patch set 1 V -1 02/23/17, 18:33 Completed build in 06m 53s on Thu, 23 Feb, 07:33 PM Test Summary: 1 of 56456 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8424

  3. Jasmina Ließmann voted on patch set 1 V +1 02/24/17, 14:43

  4. Georg Ringer uploaded patch set 2 02/24/17, 18:57

  5. TYPO3com voted on patch set 2 V +1 02/24/17, 19:04 Completed build in 06m 52s on Fri, 24 Feb, 08:04 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8519

  6. Thomas Hohn voted on patch set 2 CR +1 02/24/17, 21:01

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/26/17, 20:22

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 02/26/17, 20:23

  9. Gerrit merged patch set 2 02/26/17, 20:23

  10. Stephan Großberndt commented on patch set 3 03/02/17, 20:07

    Backport to 7.6 is missing. Most of the files do not exist there.
  11. Christian Kuhn commented on patch set 3 05/12/17, 10:46

    lets skip the 7.6 here - the issue is not *that* critical imho and it's quite some work to prepare the backport in this case.