51813[BUGFIX] DB Check causes PHP warnings and errors
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Claus Due +1
- Markus Klein +1
- Nicole Hummel +1
- Christer V +1
- Anders Kostending +1
-
Verified V +2
- Christian Kuhn +2
- Nicole Hummel +1
- Christer V +1
- TYPO3com +1 CI
Issues 3
Files 3
Review log 2634
Show 79 earlier messages
-
Thomas Hohn uploaded patch set 1 02/24/17, 07:30
-
TYPO3com voted on patch set 1 V +1 02/24/17, 07:37 Completed build in 07m 05s on Fri, 24 Feb, 08:37 AM Test Summary: 56456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8443
-
Morten Pless voted on patch set 1 CR +1 02/24/17, 08:24
-
Morten Pless voted on patch set 1 V +1 02/24/17, 08:29
-
Timo Hund voted on patch set 1 CR +1 02/24/17, 08:29
-
Josef Glatz updated the commit message in patch set 2 02/24/17, 08:44
-
TYPO3com voted on patch set 2 V +1 02/24/17, 08:55 Completed build in 11m 22s on Fri, 24 Feb, 09:55 AM Test Summary: 56458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8452
-
Timo Hund voted on patch set 2 CR +1 02/24/17, 09:35
-
Christer V commented on patch set 2 CR +1 V +1 02/24/17, 09:54
This will create sql like: SELECT `uid` FROM `table` WHERE ((`field` IS NOT NULL) AND (`field` <> 0)) if field is set to 'something', it will not be returned.
-
Christer V voted on patch set 2 CR -1 V -1 02/24/17, 09:54
-
Nicole Hummel commented on patch set 2 CR -1 02/24/17, 10:13
On it -
Nicole Hummel uploaded patch set 3 02/24/17, 10:27
-
Nicole Hummel uploaded patch set 4 02/24/17, 10:28
-
TYPO3com voted on patch set 3 V +1 02/24/17, 10:34 Completed build in 06m 45s on Fri, 24 Feb, 11:34 AM Test Summary: 56458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8466
-
TYPO3com voted on patch set 4 V +1 02/24/17, 10:36 Completed build in 08m 13s on Fri, 24 Feb, 11:36 AM Test Summary: 56458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8467
-
Morten Pless voted on patch set 4 CR +1 02/24/17, 10:41
-
Thomas Hohn uploaded patch set 5 02/24/17, 10:54
-
TYPO3com voted on patch set 5 V -1 02/24/17, 11:01 Completed build in 06m 46s on Fri, 24 Feb, 12:01 PM Test Summary: 6 of 56464 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8469
-
Thomas Hohn uploaded patch set 6 02/24/17, 11:06
-
TYPO3com voted on patch set 6 V -1 02/24/17, 11:13 Completed build in 07m 22s on Fri, 24 Feb, 12:13 PM Test Summary: 6 of 56466 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8471
-
Thomas Hohn uploaded patch set 7 02/24/17, 11:19
-
TYPO3com voted on patch set 7 V +1 02/24/17, 11:24 Completed build in 05m 17s on Fri, 24 Feb, 12:24 PM Test Summary: 56466 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8473
-
Nicole Hummel voted on patch set 7 CR +1 V +1 02/24/17, 11:25
-
Christer V commented on patch set 7 02/24/17, 11:29
DatabaseIntegrityCheck.php:470Maybe use expr()->comparison instead of appending a string. -
Morten Pless voted on patch set 7 CR +1 V +1 02/24/17, 11:30
-
Thomas Hohn uploaded patch set 8 02/24/17, 11:50
-
Christer V voted on patch set 8 CR +1 V +1 02/24/17, 11:54
-
TYPO3com voted on patch set 8 V +1 02/24/17, 12:00 Completed build in 10m 19s on Fri, 24 Feb, 01:00 PM Test Summary: 57507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8477
-
Claus Due commented on patch set 8 CR +1 02/24/17, 12:36
Code looks good; I don't have any testing data that triggers the exception or wrong rendering, so I refrain from casting a "verified" vote (even though the result works on my machine!) -
Nicole Hummel voted on patch set 8 CR +1 V +1 02/24/17, 12:39
-
Markus Klein voted on patch set 8 CR +1 02/24/17, 13:55
-
Anders Kostending voted on patch set 8 CR +1 02/25/17, 09:05
-
Christian Kuhn voted on patch set 8 CR +2 V +2 02/26/17, 19:47
-
Gerrit merged patch set 8 02/26/17, 19:47