Review main Merged

51830[BUGFIX] Opening links in pop-up windows

Christer V CR +2 V +2 Easy +18 −20 updated 02/25/17, 11:35

Commit message

Moved the check for if the target is coded as a JS open window link,
to a later stage in the function.

Since Css Styled Content and Fluid Styled Content was refactored,
the target might not be set until later in the typoLink
function. This caused pop links to stop working, moving the check for a
pop up link target to a later stages fixes the problem.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Jasmina Ließmann +1
    • Timo Hund +1
    • Faton Haliti +1
    • Anders Kostending +1
  • Verified V +2
    • Nicole Hummel +2
    • Jasmina Ließmann +1
    • Timo Hund +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Christer V uploaded patch set 1 02/24/17, 13:34

  2. Christer V updated the commit message in patch set 2 02/24/17, 13:41

  3. TYPO3com voted on patch set 1 V +1 02/24/17, 13:46 Completed build in 12m 35s on Fri, 24 Feb, 02:46 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8488

  4. TYPO3com voted on patch set 2 V +1 02/24/17, 13:55 Completed build in 13m 50s on Fri, 24 Feb, 02:55 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8490

  5. Anders Kostending voted on patch set 2 CR +1 02/24/17, 14:15

  6. Faton Haliti voted on patch set 2 CR +1 02/24/17, 19:39

  7. Jasmina Ließmann voted on patch set 2 CR +1 V +1 02/25/17, 08:23

  8. Timo Hund voted on patch set 2 CR +1 V +1 02/25/17, 08:44

  9. Nicole Hummel commented on patch set 2 CR -1 02/25/17, 11:25

    On it
  10. Nicole Hummel voted on patch set 2 CR +2 V +2 02/25/17, 11:35

  11. Gerrit merged patch set 2 02/25/17, 11:35