Review main Merged

51836[BUGFIX] Correctly parse displayCond FIELD value with colons

Claus Due CR +2 V +2 Easy +6 −1 updated 02/28/17, 18:09

Commit message

This patch prevents exploding match texts which contain
colons before matching the value against the field value.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Claus Due uploaded patch set 1 02/24/17, 16:59

  2. TYPO3com voted on patch set 1 V +1 02/24/17, 17:08 Completed build in 09m 17s on Fri, 24 Feb, 06:08 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8508

  3. Claus Due commented on patch set 1 CR -1 02/24/17, 22:28

    EvaluateDisplayConditions.php:261

    missing false as third argument - will fix tomorrow if someone doesn't beat me to it.
  4. Christian Kuhn commented on patch set 1 02/26/17, 19:53

    would you like to add a unit test for that case, too?
  5. Claus Due uploaded patch set 2 02/28/17, 10:46

  6. Claus Due commented on patch set 2 02/28/17, 10:47

    Now with test. Yay!
  7. TYPO3com voted on patch set 2 V +1 02/28/17, 10:54 Completed build in 08m 12s on Tue, 28 Feb, 11:54 AM Test Summary: 56309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8744

  8. Wouter Wolters voted on patch set 2 CR +1 02/28/17, 10:58

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 02/28/17, 14:19

  10. Christian Kuhn commented on patch set 2 02/28/17, 14:19

    thank you claus.
  11. Wouter Wolters voted on patch set 2 CR +2 V +2 02/28/17, 18:09

  12. Gerrit merged patch set 2 02/28/17, 18:09