Review main Merged

51838[TASK] Move CSV fixtures handling to FunctionalTestCase

Tymoteusz Motylewski CR +2 V +2 Hard +243 −209 updated 04/25/17, 20:38

Commit message

Usage of CSV fixtures is now possible for all functional tests.
Previously it was available only for DataHandler tests.
This patch is backward compatible.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Tymoteusz Motylewski uploaded patch set 1 02/24/17, 17:42

  2. TYPO3com voted on patch set 1 V +1 02/24/17, 17:49 Completed build in 06m 52s on Fri, 24 Feb, 06:49 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8513

  3. Georg Ringer voted on patch set 1 CR +1 V +1 02/24/17, 19:04

  4. Tymoteusz Motylewski updated the commit message in patch set 2 02/25/17, 18:56

  5. TYPO3com voted on patch set 2 V +1 02/25/17, 19:02 Completed build in 06m 34s on Sat, 25 Feb, 08:02 PM Test Summary: 56394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8578

  6. Christian Kuhn commented on patch set 2 CR -1 02/26/17, 10:13

    working on it
  7. Christian Kuhn commented on patch set 2 CR 0 02/26/17, 10:22

    some comment improvements would be good, and let's clarify the method signature absolute vs. relative path thing. What do you think if we maybe importDataSet() call getFileAbsFileName() too, or remove these calls from the other two methods?

    FunctionalTestCase.php:374

    one thing i don't like here with the method signature is that the "xml" import method "importDataSet()" accepts only a fully resolved file name, while this one here can handle EXT: syntax. So two methods doing similar stuff with different signatures.

    FunctionalTestCase.php:397

    similar question.

    FunctionalTestCase.php:442

    let's have some explaining method comment here.

    FunctionalTestCase.php:460

    how and where is this used? helper method for...

    FunctionalTestCase.php:488

    some comment "helper method for...."

    FunctionalTestCase.php:504

    output helper method

    FunctionalTestCase.php:564

    helper method for ... "you usually don't need to call that on your own"
  8. Christian Kuhn commented on patch set 2 CR -1 02/26/17, 18:59

    -1 for the time being, please ping me if you want help with a decision, tymek.
  9. Tymoteusz Motylewski uploaded patch set 3 02/27/17, 08:33

  10. TYPO3com voted on patch set 3 V -1 02/27/17, 08:44 Completed build in 10m 41s on Mon, 27 Feb, 09:44 AM Test Summary: 1304 of 56417 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8675

  11. Tymoteusz Motylewski uploaded patch set 4 02/27/17, 08:45

  12. TYPO3com voted on patch set 4 V +1 02/27/17, 08:52 Completed build in 07m 00s on Mon, 27 Feb, 09:52 AM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8676

  13. Christian Kuhn voted on patch set 4 CR +1 V +1 02/27/17, 14:46

  14. Anja Leichsenring voted on patch set 4 CR +2 V +2 02/27/17, 17:26

  15. Gerrit merged patch set 4 02/27/17, 17:26

  16. Stephan Großberndt commented on patch set 5 04/25/17, 09:19

    Backport to 7.6 is missing
  17. Tymoteusz Motylewski commented on patch set 5 04/25/17, 20:38

    working on backport