51838[TASK] Move CSV fixtures handling to FunctionalTestCase
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1317
-
Tymoteusz Motylewski uploaded patch set 1 02/24/17, 17:42
-
TYPO3com voted on patch set 1 V +1 02/24/17, 17:49 Completed build in 06m 52s on Fri, 24 Feb, 06:49 PM Test Summary: 57501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8513
-
Georg Ringer voted on patch set 1 CR +1 V +1 02/24/17, 19:04
-
Tymoteusz Motylewski updated the commit message in patch set 2 02/25/17, 18:56
-
TYPO3com voted on patch set 2 V +1 02/25/17, 19:02 Completed build in 06m 34s on Sat, 25 Feb, 08:02 PM Test Summary: 56394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8578
-
Christian Kuhn commented on patch set 2 CR -1 02/26/17, 10:13
working on it -
Christian Kuhn commented on patch set 2 CR 0 02/26/17, 10:22
some comment improvements would be good, and let's clarify the method signature absolute vs. relative path thing. What do you think if we maybe importDataSet() call getFileAbsFileName() too, or remove these calls from the other two methods?FunctionalTestCase.php:374one thing i don't like here with the method signature is that the "xml" import method "importDataSet()" accepts only a fully resolved file name, while this one here can handle EXT: syntax. So two methods doing similar stuff with different signatures.FunctionalTestCase.php:397similar question.FunctionalTestCase.php:442let's have some explaining method comment here.FunctionalTestCase.php:460how and where is this used? helper method for...FunctionalTestCase.php:488some comment "helper method for...."FunctionalTestCase.php:504output helper methodFunctionalTestCase.php:564helper method for ... "you usually don't need to call that on your own" -
Christian Kuhn commented on patch set 2 CR -1 02/26/17, 18:59
-1 for the time being, please ping me if you want help with a decision, tymek. -
Tymoteusz Motylewski uploaded patch set 3 02/27/17, 08:33
-
TYPO3com voted on patch set 3 V -1 02/27/17, 08:44 Completed build in 10m 41s on Mon, 27 Feb, 09:44 AM Test Summary: 1304 of 56417 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8675
-
Tymoteusz Motylewski uploaded patch set 4 02/27/17, 08:45
-
TYPO3com voted on patch set 4 V +1 02/27/17, 08:52 Completed build in 07m 00s on Mon, 27 Feb, 09:52 AM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8676
-
Christian Kuhn voted on patch set 4 CR +1 V +1 02/27/17, 14:46
-
Anja Leichsenring voted on patch set 4 CR +2 V +2 02/27/17, 17:26
-
Gerrit merged patch set 4 02/27/17, 17:26
-
Stephan Großberndt commented on patch set 5 04/25/17, 09:19
Backport to 7.6 is missing -
Tymoteusz Motylewski commented on patch set 5 04/25/17, 20:38
working on backport