Review main Merged

51856[TASK] Add language debug mode to All Configuration

Thomas Hohn CR +2 V +2 Normal +118 −6 updated 03/01/17, 10:55

Commit message

Renamed $TYPO3_CONF_VARS['BE']['lang']['debug'] to
$TYPO3_CONF_VARS['BE']['languageDebug'] in order to
be able to set value in install-tool.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1013

  1. Thomas Hohn uploaded patch set 1 02/25/17, 14:32

  2. TYPO3com voted on patch set 1 V +1 02/25/17, 14:43 Completed build in 10m 19s on Sat, 25 Feb, 03:43 PM Test Summary: 57507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8559

  3. Xavier Perseguers voted on patch set 1 CR +1 02/26/17, 16:48

  4. Christian Kuhn commented on patch set 1 CR -1 02/26/17, 17:07

    It should be pretty easy to add a SilentConfigurationUpgradeService entry to move from old to new setting in LocalConfiguration automatically. Have a small method in there and maybe a unit test.
  5. Thomas Hohn commented on patch set 1 02/26/17, 17:33

    Christian are there any examples where i could look into?
  6. Christian Kuhn commented on patch set 1 02/26/17, 22:44

    sure. the silent config upgrader is full of examples where localConfiguration values are moved around.
  7. Thomas Hohn uploaded patch set 2 02/28/17, 07:05

  8. TYPO3com voted on patch set 2 V +1 02/28/17, 07:13 Completed build in 08m 34s on Tue, 28 Feb, 08:13 AM Test Summary: 56309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8726

  9. Thomas Hohn uploaded patch set 3 03/01/17, 06:02

  10. TYPO3com voted on patch set 3 V +1 03/01/17, 06:09 Completed build in 06m 59s on Wed, 1 Mar, 07:09 AM Test Summary: 56333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8784

  11. Benni Mack voted on patch set 3 CR +1 V +1 03/01/17, 10:48

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 03/01/17, 10:55

  13. Gerrit merged patch set 3 03/01/17, 10:55