Review TYPO3_7-6 Merged

51868[BUGFIX] Fix parameter type in BackendModuleRequestHandler

Benni Mack CR +2 V +2 Easy +2 −1 updated 02/27/17, 06:29

Commit message

The function
\TYPO3\CMS\Core\Authentication\BackendUserAuthentication
->getPagePermsClause accepts only an integer value as parameter,
but a boolean value is given in
TYPO3\CMS\Backend\Http\BackendModuleRequestHandler->dispatchModule

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Thomas Hohn +1
    • Markus Hölzle +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Hölzle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 02/27/17, 05:37

  2. TYPO3com voted on patch set 1 V +1 02/27/17, 05:41 Completed build in 03m 35s on Mon, 27 Feb, 06:41 AM Test Summary: 38579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-771

  3. Markus Hölzle voted on patch set 1 CR +1 V +1 02/27/17, 05:49

  4. Thomas Hohn voted on patch set 1 CR +1 02/27/17, 05:54

  5. Wouter Wolters voted on patch set 1 CR +2 V +2 02/27/17, 06:29

  6. Gerrit merged patch set 1 02/27/17, 06:29