Review main Merged

51870[TASK] Add addTop/removeTop row in backend layout wizard

Georg Ringer CR +2 V +2 Normal +78 −12 updated 02/27/17, 17:30

Commit message

Improve the backend layout wizard by providing additional buttons to
add and remove rows at the top.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Georg Ringer uploaded patch set 1 02/27/17, 07:39

  2. TYPO3com voted on patch set 1 V +1 02/27/17, 07:49 Completed build in 10m 06s on Mon, 27 Feb, 08:49 AM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8674

  3. Benni Mack updated the commit message in patch set 2 02/27/17, 08:54

  4. Benni Mack voted on patch set 2 CR +1 02/27/17, 08:54

  5. TYPO3com voted on patch set 2 V +1 02/27/17, 09:08 Completed build in 13m 55s on Mon, 27 Feb, 10:08 AM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8677

  6. Christian Kuhn commented on patch set 2 V -1 02/27/17, 12:27

    the bottom-row "up" button to remove a row is broken with that patch applied.
  7. Josef Glatz commented on patch set 2 V -1 02/27/17, 15:51

    Nice! But I could also confirm Christian's problem after applying the patch
  8. Josef Glatz uploaded patch set 3 02/27/17, 16:32

  9. Josef Glatz commented on patch set 3 CR +1 V +1 02/27/17, 16:34

    @loli fixed it
  10. TYPO3com voted on patch set 3 V +1 02/27/17, 16:40 Completed build in 07m 28s on Mon, 27 Feb, 05:40 PM Test Summary: 56423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8696

  11. Benni Mack voted on patch set 3 CR +1 02/27/17, 17:01

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 02/27/17, 17:30

  13. Gerrit merged patch set 3 02/27/17, 17:30