51873[TASK] Display file field in sys_file_metadata
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 610
-
Anja Leichsenring uploaded patch set 1 02/27/17, 12:32
-
Anja Leichsenring uploaded patch set 2 02/27/17, 12:36
-
Anja Leichsenring updated the commit message in patch set 3 02/27/17, 12:41
-
Anja Leichsenring updated the commit message in patch set 4 02/27/17, 12:41
-
TYPO3com voted on patch set 1 V +1 02/27/17, 12:41 Completed build in 08m 57s on Mon, 27 Feb, 01:41 PM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8683
-
TYPO3com voted on patch set 2 V +1 02/27/17, 12:45 Completed build in 08m 56s on Mon, 27 Feb, 01:45 PM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8684
-
TYPO3com voted on patch set 3 V +1 02/27/17, 12:50 Completed build in 09m 07s on Mon, 27 Feb, 01:50 PM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8685
-
TYPO3com voted on patch set 4 V +1 02/27/17, 12:53 Completed build in 11m 35s on Mon, 27 Feb, 01:53 PM Test Summary: 56417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8686
-
Christian Kuhn commented on patch set 4 V -1 02/27/17, 13:05
not a big fan. the "information" field already shows filename (and size and image preview and more). thus, adding that field to the view basically just adds redundant information. -
Anja Leichsenring abandoned the change 02/27/17, 13:17
d'accore. I am not convinced either. Will think about something different.