Review main Merged

51874[TASK] Replace FileInfoHook with renderType

Anja Leichsenring CR +2 V +2 Normal +29 −33 updated 02/27/17, 18:07

Commit message

Switch a userFunc to a proper renderType used in fileinfo field
of sys_file and sys_file_metadata table.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1623

  1. Anja Leichsenring uploaded patch set 1 02/27/17, 14:01

  2. Anja Leichsenring uploaded patch set 2 02/27/17, 14:02

  3. Anja Leichsenring uploaded patch set 3 02/27/17, 14:03

  4. Anja Leichsenring uploaded patch set 4 02/27/17, 14:04

  5. Anja Leichsenring uploaded patch set 5 02/27/17, 14:05

  6. TYPO3com voted on patch set 1 V -1 02/27/17, 14:11 Completed build in 10m 23s on Mon, 27 Feb, 03:11 PM Test Summary: 56423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8690

  7. TYPO3com voted on patch set 2 V -1 02/27/17, 14:13 Completed build in 11m 39s on Mon, 27 Feb, 03:13 PM Test Summary: 1 of 56423 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8691

  8. TYPO3com voted on patch set 3 V -1 02/27/17, 14:14 Completed build in 11m 19s on Mon, 27 Feb, 03:14 PM Test Summary: 56423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8692

  9. TYPO3com voted on patch set 4 V +1 02/27/17, 14:17 Completed build in 12m 30s on Mon, 27 Feb, 03:17 PM Test Summary: 56423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8693

  10. TYPO3com voted on patch set 5 V +1 02/27/17, 14:18 Completed build in 13m 11s on Mon, 27 Feb, 03:18 PM Test Summary: 56423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8694

  11. Wouter Wolters commented on patch set 5 02/27/17, 14:25

    FileInfoElement.php:35

    : array

    FileInfoElement.php:60

    : string
  12. Anja Leichsenring uploaded patch set 6 02/27/17, 14:26

  13. Wouter Wolters voted on patch set 6 CR +1 02/27/17, 14:28

  14. Thomas Hohn voted on patch set 6 CR +1 02/27/17, 14:31

  15. TYPO3com voted on patch set 6 V +1 02/27/17, 14:35 Completed build in 09m 20s on Mon, 27 Feb, 03:35 PM Test Summary: 56423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8695

  16. Josef Glatz voted on patch set 6 CR +1 V +1 02/27/17, 16:09

  17. Christian Kuhn uploaded patch set 7 02/27/17, 17:07

  18. Christian Kuhn commented on patch set 7 CR +1 V +1 02/27/17, 17:08

    Cosmetic changes only.
  19. TYPO3com voted on patch set 7 V +1 02/27/17, 17:14 Completed build in 06m 39s on Mon, 27 Feb, 06:14 PM Test Summary: 56423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8697

  20. Josef Glatz voted on patch set 7 CR +1 V +1 02/27/17, 17:32

  21. Wouter Wolters voted on patch set 7 CR +1 02/27/17, 17:32

  22. Christian Kuhn voted on patch set 7 CR +2 V +2 02/27/17, 18:07

  23. Gerrit merged patch set 7 02/27/17, 18:07