Review main Merged

51876[BUGFIX] Set file size to 0 instead to string in ImportExport

Georg Ringer CR +2 V +2 Easy +2 −2 updated 02/28/17, 14:02

Commit message

To avoid errors with PHP 7.1 which is more strict regarding
strings and integers, the file size for soft refs must be
set to 0 instead of an empty string.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 02/27/17, 19:31

  2. TYPO3com voted on patch set 1 V +1 02/27/17, 19:38 Completed build in 07m 17s on Mon, 27 Feb, 08:38 PM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8706

  3. Thomas Hohn voted on patch set 1 CR +1 02/27/17, 19:45

  4. Josef Glatz voted on patch set 1 CR +1 02/27/17, 19:55

  5. Wouter Wolters voted on patch set 1 CR +1 02/27/17, 21:09

  6. Markus Klein commented on patch set 1 02/27/17, 21:29

    ImportExport.php:615

    int cast here too?
  7. Georg Ringer uploaded patch set 2 02/28/17, 08:08

  8. TYPO3com voted on patch set 2 V +1 02/28/17, 08:15 Completed build in 07m 01s on Tue, 28 Feb, 09:15 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8732

  9. Josef Glatz voted on patch set 2 CR +1 02/28/17, 08:16

  10. Markus Klein voted on patch set 2 CR +1 V +1 02/28/17, 12:28

  11. Christian Kuhn voted on patch set 2 CR +2 V +2 02/28/17, 14:02

  12. Gerrit merged patch set 2 02/28/17, 14:02