51882[FEATURE] Add Oracle database (oci8) support for the first install tool
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 7
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaColumnDefinitionListener.php+5 −1
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+59 −7
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+33 −4
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php+273 −51
- typo3/sysext/install/Classes/Controller/Action/Step/DatabaseSelect.php+20 −0
- typo3/sysext/install/Resources/Private/Partials/Action/Step/DatabaseConnect/ConnectDetails.html+69 −2
- typo3/sysext/install/Resources/Public/JavaScript/Install.js+110 −6
Review log 1315
-
Mathieu Bouchard uploaded patch set 1 02/28/17, 05:49
-
TYPO3com voted on patch set 1 V -1 02/28/17, 05:59 Completed build in 09m 33s on Tue, 28 Feb, 06:59 AM Test Summary: 1 of 56297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8720
-
Christian Kuhn commented on patch set 1 02/28/17, 08:50
Hey Mathieu. Thanks for your patch. This looks clean at first glance and reads well. However, it may happen that your patch will lie around for some weeks until we take a closer look at it, since we are currently first dealing with mssql and sqlite. We're currently still busy with dbms support for v8 lts, here is what this part from the active core team group is currently dealing with: * (done) have green postgres functionals and execute them on each patch set * add and run postgres acceptance tests an each patch set and fix if not green - this will ensure critical parts of the BE actually work * add both sqlite and mssql to test agents * make sqlite functionals green in test testbed, then add as mainline tests * make mssql functionals green in test testbed, then add as mainline tests - first steps show that mssql is even more bitchy about column types than postgres * add a basic acceptance test to click through the installer, first with mysql. this will require a different codeception boostrap. add to mainline test * add postgres to step 2/3 of install tool, prepare these steps for other databases * run "basic installer tests" with postgres, then sqlite and mssql * add oracle to test images (needs clearification of license since the images are available on hub.docker.io), then get functionals green with oracle and run them, add support to installer, change acceptance installer test to run with oracle, run acceptance tests with oracle So, the current planning is to first tackle sqlite + mssql, then have a closer look at oracle. -
Mathieu Bouchard uploaded patch set 2 03/01/17, 03:17
-
Mathieu Bouchard commented on patch set 2 03/01/17, 03:19
Updated the code to remove trailing space and use tabs on HTML and JavaScript code. -
TYPO3com voted on patch set 2 V -1 03/01/17, 03:26 Completed build in 09m 25s on Wed, 1 Mar, 04:26 AM Test Summary: 1 of 56321 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8779
-
Mathieu Bouchard commented on patch set 2 03/01/17, 03:30
Hi Christian, Thanks for the reply. As you know, the code to add Oracle support on step 2/3 is not optimal since each new database added to the install tool add a complex logic both in the PHP and JavaScript code. For the rest of the Oracle support, here's what I will have to look for: - Trivial: Make sure that every use of an identifier (table name, column, index, etc.) - Trivial: Modify the lastInsertId method to add support for Oracle sequences - Medium: Add support for Oracle CLOB (Oracle doesn't allow the use of SQL functions like =, <>, etc. to - Medium: Finish the support for Oracle 30 character limit on table names CLOB). The quick fix is to cast the CLOB to char. Each case will have to be reviewed, but for now I identified that it will limit the URL length to 4000 characters when using an Oracle Database. - Difficult: Oracle automatically transform empty strings ('') to NULL. Each usage of a column that is defined as NOT NULL DEFAULT '' will have to be modified. And maybe add a default config when using Oracle for the table name mapping: 'TableNameMappings' => [ 'cf_cache_pagesection_tags' => 'or_cache_pgsec_tags', 'cf_extbase_datamapfactory_datamap' => 'or_datamap', 'cf_extbase_datamapfactory_datamap_tags' => 'or_datamap_tags', 'cf_extbase_reflection_tags' => 'or_extref_tags', 'tx_extensionmanager_domain_model_extension' => 'or_extman_ext', 'tx_extensionmanager_domain_model_repository' => 'or_extman_rep', ], -
Mathieu Bouchard commented on patch set 2 03/01/17, 03:31
Trivial: Make sure that every use of an identifier (table name, column, index, etc.) is quoted -
Mathieu Bouchard commented on patch set 2 03/01/17, 03:33
Don't know what happened to my comment, but it should read: - Medium: Add support for Oracle CLOB (Oracle doesn't allow the use of SQL functions like =, <>, etc. with a CLOB) The quick fix is to cast the CLOB to char. Each case will have to be reviewed, but for now I identified that it will limit the URL length to 4000 characters when using an Oracle Database. - Medium: Finish the support for Oracle 30 character limit on table names CLOB). -
Mathias Schreiber commented on patch set 2 02/07/18, 20:05
Mathieu, is this still a task you're up to? Thing is that the install tool has been rewritten completely. Hence we will abandon this change for now. You can open it up again whenever you like if you want to go on with adjusting it with the new installer. -
Andreas Kienast abandoned the change 02/07/18, 20:05
-
Mathieu Bouchard commented on patch set 2 02/09/18, 21:05
Hi Mathias, We are still working on this. The install tool patch is but a tiny part of the modifications required to support Oracle with TYPO3. Since last year, we did put in production our website using Oracle as a database server and updated the patch multiple times as testing was ongoing. Some of the work cannot be merged as is, since some corners were cut and part of the code will only work with Oracle. I plan on updating it and push a cleaned up version in the future. The patch is currently at almost 4500 lines. In fact, we are waiting for an upgrade to Oracle 12.2 to drop some of the more invasive changes to support the limit of Oracle identifiers that were limited to 30 characters. -
Mathias Schreiber commented on patch set 2 02/09/18, 21:06
A-MA-ZING :) Although 4500 LOC patches sounds pretty intimidating. Let's try to fiddle around tearing the monster to pieces and work through it bit by bit. What do you think? -
Mathieu Bouchard commented on patch set 2 02/09/18, 21:09
That's the plan. The only thing missing is some time :) -
Susi Moog commented on patch set 2 03/01/19, 18:29
Hey, it's a year later and I wanted to ask if you might find some time to work on this in the (near) future?