Review main Merged

51885[BUGFIX] Always use system getFrom() when sending emails

Benni Mack CR +2 V +2 Easy +13 −16 updated 02/28/17, 14:30

Commit message

When instantiating MailMessage() and no valid sender is
given, a fallback is used in different places of TYPO3. To ensure
that all mails sent out (e.g. when instantiated via extensions)
have a proper From() header, the default fallback is set
just before sending the emails.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 68

  1. Benni Mack uploaded patch set 1 02/28/17, 06:40

  2. TYPO3com voted on patch set 1 V -1 02/28/17, 06:48 Completed build in 07m 57s on Tue, 28 Feb, 07:48 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8724

  3. Benni Mack uploaded patch set 2 02/28/17, 09:21

  4. TYPO3com voted on patch set 2 V +1 02/28/17, 09:30 Completed build in 09m 44s on Tue, 28 Feb, 10:30 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8735

  5. Wouter Wolters voted on patch set 2 CR +1 02/28/17, 09:32

  6. Georg Ringer voted on patch set 2 CR +1 V +1 02/28/17, 09:47

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 02/28/17, 14:30

  8. Gerrit merged patch set 2 02/28/17, 14:30