Review main Merged

51893[SECURITY] Prevent possible XSS in Fluid templates

Oliver Hader CR +2 V +2 Easy +3 −3 updated 02/28/17, 10:39

Commit message

This patch ensures proper encoding of the output of if-ViewHelpers when
using in inline notation.

The regular expression to find possibly affected usages is:
\{\s*f:if\s*\(.+,\s*(?:then|else):(?>\s*)[^']

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 3

Review log 35

  1. Oliver Hader uploaded patch set 1 02/28/17, 10:23

  2. Oliver Hader commented on patch set 1 CR +2 V +2 02/28/17, 10:23

    Auto-approved
  3. Gerrit merged patch set 1 02/28/17, 10:24

  4. TYPO3com commented on patch set 1 02/28/17, 10:35 Completed build in 11m 55s on Tue, 28 Feb, 11:35 AM Test Summary: 1 of 56297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8742

  5. TYPO3com commented on patch set 1 02/28/17, 10:39 Completed build in 27m 33s on Tue, 28 Feb, 11:39 AM Test Summary: 56297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8742