Review main Merged

51902[BUGFIX] Add query restrictions for all tables in query

Tymoteusz Motylewski CR +2 V +2 Normal +92 −66 updated 03/01/17, 11:24

Commit message

QueryBuilder::getQueriedTables now returns an array with table
alias as a key and table name as value.
If a table doesn't have an alias, both key and value are containing
table name.

This change is needed to make query restriction classes add restrictions
for all tables in case the self inner join is made.
A test covering the case was added to QueryBuilderTest.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Patrick Broens +1
    • Morton Jonuschat +1
  • Verified V +2
    • Georg Ringer +2
    • Patrick Broens +1
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 22

Show 2 more files

Review log 1216

  1. Tymoteusz Motylewski uploaded patch set 1 02/28/17, 14:28

  2. TYPO3com voted on patch set 1 V -1 02/28/17, 14:34 Completed build in 06m 28s on Tue, 28 Feb, 03:34 PM Test Summary: 157 of 56297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8751

  3. Tymoteusz Motylewski uploaded patch set 2 02/28/17, 14:50

  4. TYPO3com voted on patch set 2 V -1 02/28/17, 14:57 Completed build in 06m 19s on Tue, 28 Feb, 03:57 PM Test Summary: 48 of 56309 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8754

  5. Tymoteusz Motylewski uploaded patch set 3 02/28/17, 15:08

  6. TYPO3com voted on patch set 3 V +1 02/28/17, 15:14 Completed build in 06m 33s on Tue, 28 Feb, 04:14 PM Test Summary: 56309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8755

  7. Tymoteusz Motylewski uploaded patch set 4 02/28/17, 15:51

  8. TYPO3com voted on patch set 4 V +1 02/28/17, 15:59 Completed build in 07m 50s on Tue, 28 Feb, 04:59 PM Test Summary: 56315 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8758

  9. Morton Jonuschat voted on patch set 4 CR +1 V +1 03/01/17, 07:52

  10. Patrick Broens voted on patch set 4 CR +1 V +1 03/01/17, 08:11

  11. Georg Ringer voted on patch set 4 CR +2 V +2 03/01/17, 08:26

  12. Gerrit merged patch set 4 03/01/17, 08:26

  13. Nicole Hummel commented on patch set 5 03/01/17, 10:47

    Post -1: Due to this change it is now possible (again) do login in with an restricted (e.g. disabled) frontend user. I will care about an update ASAP.
  14. Nicole Hummel commented on patch set 5 03/01/17, 10:53

  15. Nicole Hummel commented on patch set 5 03/01/17, 10:54

    IMHO this is a breaking change of the doctrine api and needs a proper rst documentation. As now key and value is switched and with the old usage no TCA information is found anymore (see bugfix of user authentication). I would kindly ask you to add some rst file in the follow up)
  16. Tymoteusz Motylewski commented on patch set 5 03/01/17, 11:24

    oh, damn, you're totally right Nicole. Thanks for spotting it and sorry for that.