Review main Merged

51907[BUGFIX] Check for required migrations in silentCacheFrameworkTableSchemaMigration

Georg Ringer CR +2 V +2 Easy +4 −2 updated 03/06/17, 07:39

Commit message

Check that there are tables that need to be migrated instead of blindy
calling the SchemaMigrator.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Thomas Hohn +1
    • Morton Jonuschat +1
  • Verified V +2
    • Georg Ringer +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1416

  1. Georg Ringer uploaded patch set 1 02/28/17, 19:15

  2. Andreas Kienast voted on patch set 1 CR +1 02/28/17, 19:16

  3. TYPO3com voted on patch set 1 V +1 02/28/17, 19:24 Completed build in 08m 48s on Tue, 28 Feb, 08:24 PM Test Summary: 56321 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8772

  4. Thomas Hohn voted on patch set 1 CR +1 02/28/17, 20:36

  5. Markus Klein commented on patch set 1 CR -1 02/28/17, 21:24

    SchemaMigrator.php:270

    IMO this must be a guard clause at the top. $tables can never be empty if any statement is present. if (empty($statements))
  6. Morton Jonuschat commented on patch set 1 03/01/17, 07:47

    We should definitely figure out why no statements were passed in. Wether this guard clause is above or below the loop is secondary in my opinion, the loop is basically a no-op on an empty array.
  7. Josef Glatz commented on patch set 1 03/01/17, 12:13

    Maybe this helps: I can reproduce this issue with my TYPO3 master instance, which I started while 8.6.0-dev was latest. Now I get the same exception if I open the Upgrade Wizard within the TYPO3 install tool. Basically, the error is gone when I apply the patch
  8. Morton Jonuschat commented on patch set 1 03/03/17, 03:28

    @Josef, can you try to figure out where the statements get lost?
  9. Georg Ringer commented on patch set 1 03/03/17, 06:56

    @morton: i sent you a slack message with access to a system where you can reproduce that
  10. Morton Jonuschat commented on patch set 1 03/04/17, 01:39

    This seems to be triggered by TYPO3\CMS\Install\Controller\Action\Tool\UpgradeWizard::silentCacheFrameworkTableSchemaMigration(), investigating
  11. Morton Jonuschat uploaded patch set 2 03/04/17, 01:58

  12. TYPO3com voted on patch set 2 V +1 03/04/17, 02:08 Completed build in 09m 44s on Sat, 4 Mar, 03:08 AM Test Summary: 56398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8876

  13. Morton Jonuschat voted on patch set 2 CR +1 V +1 03/04/17, 02:09

  14. Thomas Hohn voted on patch set 2 CR +1 03/04/17, 07:37

  15. Georg Ringer voted on patch set 2 CR +2 V +2 03/06/17, 07:38

  16. Gerrit merged patch set 2 03/06/17, 07:39