51912[FOLLOWUP][BUGFIX] Add query restrictions for all tables in query
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Thomas Hohn +1
- Wouter Wolters +1
- Jigal van Hemert +1
- Nicole Hummel +1
-
Verified V +2
- Georg Ringer +2
- Jigal van Hemert +1
- Nicole Hummel +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1417
-
Nicole Hummel uploaded patch set 1 03/01/17, 10:52
-
Nicole Hummel commented on patch set 1 CR -1 03/01/17, 10:54
Needs an rst file with documentation of a different usage of that api now. -
TYPO3com voted on patch set 1 V +1 03/01/17, 11:00 Completed build in 07m 17s on Wed, 1 Mar, 12:00 PM Test Summary: 56367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8794
-
Tymoteusz Motylewski commented on patch set 1 03/01/17, 11:28
Thanks a lot, I will add push a new patchset with RST -
Tymoteusz Motylewski uploaded patch set 2 03/01/17, 14:17
-
TYPO3com voted on patch set 2 V +1 03/01/17, 14:26 Completed build in 09m 09s on Wed, 1 Mar, 03:26 PM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8813
-
Georg Ringer voted on patch set 2 CR +1 V +1 03/01/17, 17:12
-
Nicole Hummel commented on patch set 2 03/01/17, 17:19
Breaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:14As far as I got the change, none of both (array key and value) should be empty by now and needs to be filled, right?Breaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:22why would we have this alias here?Breaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:38do you mean "rely"?Breaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:52to be able to handle the new incoming array structure -
Tymoteusz Motylewski uploaded patch set 3 03/02/17, 08:58
-
Tymoteusz Motylewski commented on patch set 2 03/02/17, 08:58
Breaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:14ReplyDoneBreaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:22ReplyDoneBreaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:38ReplyDoneBreaking-79615-QueryBuilderGetQueriedTablesResultFormatChange.rst:52ReplyDone -
TYPO3com voted on patch set 3 V +1 03/02/17, 09:07 Completed build in 09m 24s on Thu, 2 Mar, 10:07 AM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8828
-
Nicole Hummel commented on patch set 3 CR +1 V +1 03/03/17, 09:33
Thank you Tymec! -
Wouter Wolters voted on patch set 3 CR +1 03/03/17, 10:53
-
Thomas Hohn voted on patch set 3 CR +1 03/03/17, 11:26
-
Jigal van Hemert voted on patch set 3 CR +1 V +1 03/03/17, 12:05
-
Georg Ringer voted on patch set 3 CR +2 V +2 03/03/17, 19:05
-
Gerrit merged patch set 3 03/03/17, 19:05