Review main Merged

51914[TASK] Deprecate page.insertClassesFromRTE

Benni Mack CR +2 V +2 Easy +44 −0 updated 03/01/17, 12:44

Commit message

The TypoScript option which fetches TSconfig to
load RTE specific classes and writes inline CSS
has been marked as deprecated, as the cross-dependency
for RTE/pageTSconfig/TypoScript is superseeded by
modern techniques of having a separate frontend from
the backend styling - using contents.css for that
case, and LESS/SASS/preprocessing for frontend
rendering.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 03/01/17, 11:30

  2. TYPO3com voted on patch set 1 V +1 03/01/17, 11:40 Completed build in 09m 47s on Wed, 1 Mar, 12:40 PM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8798

  3. Benni Mack uploaded patch set 2 03/01/17, 12:09

  4. TYPO3com voted on patch set 2 V +1 03/01/17, 12:16 Completed build in 07m 09s on Wed, 1 Mar, 01:16 PM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8803

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 03/01/17, 12:18

  6. Wouter Wolters commented on patch set 2 03/01/17, 12:19

    Deprecation-80076-TypoScriptOptionPageinsertClassesFromRTE.rst:12

    single `

    Deprecation-80076-TypoScriptOptionPageinsertClassesFromRTE.rst:14

    defined is twice in this sentence, doesn;t read well IMO

    Deprecation-80076-TypoScriptOptionPageinsertClassesFromRTE.rst:22

    single `
  7. Christian Kuhn commented on patch set 2 CR -1 03/01/17, 12:28

    will update
  8. Christian Kuhn uploaded patch set 3 03/01/17, 12:32

  9. Wouter Wolters voted on patch set 3 CR +1 V +1 03/01/17, 12:36

  10. TYPO3com voted on patch set 3 V +1 03/01/17, 12:43 Completed build in 10m 37s on Wed, 1 Mar, 01:43 PM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8808

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 03/01/17, 12:44

  12. Gerrit merged patch set 3 03/01/17, 12:44