Review main Merged

51917[BUGFIX] Ensure pageTS is overriding on top-level RTE syntax

Benni Mack CR +2 V +2 Normal +187 −25 updated 03/02/17, 12:45

Commit message

If using RTE.classesAnchor before, the new Richtext class
did not merge the values together. This is now solved by
doing proper overlays.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Benni Mack uploaded patch set 1 03/01/17, 11:52

  2. TYPO3com voted on patch set 1 V +1 03/01/17, 12:00 Completed build in 08m 03s on Wed, 1 Mar, 01:00 PM Test Summary: 56379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8801

  3. Christian Kuhn commented on patch set 1 03/01/17, 12:06

    Richtext.php:70

    maybe needs an if isset()?

    Richtext.php:71

    here too?

    Richtext.php:87

    isset() in front of is_array()
  4. Benni Mack uploaded patch set 2 03/01/17, 12:17

  5. TYPO3com voted on patch set 2 V -1 03/01/17, 12:24 Completed build in 07m 17s on Wed, 1 Mar, 01:24 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8805

  6. Christian Kuhn uploaded patch set 3 03/01/17, 12:35

  7. TYPO3com voted on patch set 3 V +1 03/01/17, 12:43 Completed build in 07m 12s on Wed, 1 Mar, 01:43 PM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8809

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 03/01/17, 12:45

  9. Wouter Wolters voted on patch set 3 CR +1 03/01/17, 12:58

  10. Helmut Hummel voted on patch set 3 CR +1 03/01/17, 13:53

  11. Helmut Hummel commented on patch set 3 V -1 03/01/17, 13:54

    will test this now
  12. Helmut Hummel commented on patch set 3 CR +2 V +2 03/02/17, 12:44

    works perfectly, thanks
  13. Gerrit merged patch set 3 03/02/17, 12:45