Review main Merged

51932[TASK] Use LanguageService::$moduleLabels as fallback in ModuleLoader

Nicole Hummel CR +2 V +2 Easy +12 −0 updated 03/04/17, 02:15

Commit message

As the property moduleLabels of the LanguageService was deprecated with
8, it should be used as fallback for module labels unless it is removed
completely. This raises compatibility possibilities for extensions as
otherwise an empty module is shown in the module list.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Thomas Hohn +1
    • Benni Mack +1
  • Verified V +2
    • Morton Jonuschat +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Nicole Hummel uploaded patch set 1 03/02/17, 23:19

  2. TYPO3com voted on patch set 1 V +1 03/02/17, 23:26 Completed build in 07m 10s on Fri, 3 Mar, 12:26 AM Test Summary: 56397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8845

  3. Frans Saris commented on patch set 1 03/03/17, 06:34

    But this will not create deprecating log messages, correct?
  4. Nicole Hummel commented on patch set 1 03/03/17, 10:48

    @Frans: deprecate a property is quite difficult as you cannot track its usage. So no, deprecation is only visible in IDE afaik and doesn't log or show any message
  5. Thomas Hohn voted on patch set 1 CR +1 03/03/17, 11:05

  6. Benni Mack voted on patch set 1 CR +1 V +1 03/03/17, 12:48

  7. Morton Jonuschat voted on patch set 1 CR +2 V +2 03/04/17, 02:15

  8. Gerrit merged patch set 1 03/04/17, 02:15